identatoin

src/main/java/com/dccorp/urlshortner/WebSecurityConfiguration.java

@@ -26,8 +26,8 @@
 @EnableWebSecurity
 public class WebSecurityConfiguration extends WebSecurityConfigurerAdapter {
 
-    private BCryptPasswordEncoder bCryptPasswordEncoder;
-    private UserDetailsServiceImpl userDetailsService;
+    private final BCryptPasswordEncoder bCryptPasswordEncoder;
+    private final UserDetailsServiceImpl userDetailsService;
 
     private static final String[] AUTH_WHITELIST = {
             "/v2/api-docs",

src/main/java/com/dccorp/urlshortner/entity/AppUser.java

@@ -19,7 +19,7 @@
 public class AppUser implements Serializable {
 
     @Id
-    @GeneratedValue(strategy =  GenerationType.IDENTITY)
+    @GeneratedValue(strategy = GenerationType.IDENTITY)
     private long id;
 
     @Column(name = "first_name")

src/main/java/com/dccorp/urlshortner/security/AuthenticationFilter.java

@@ -25,7 +25,7 @@
 @Slf4j
 public class AuthenticationFilter extends UsernamePasswordAuthenticationFilter {
 
-    private AuthenticationManager authenticationManager;
+    private final AuthenticationManager authenticationManager;
 
     public AuthenticationFilter(AuthenticationManager authenticationManager) {
         this.authenticationManager = authenticationManager;

src/main/java/com/dccorp/urlshortner/security/UserDetailsServiceImpl.java

@@ -18,7 +18,7 @@
 @Service
 public class UserDetailsServiceImpl implements UserDetailsService {
 
-    private RegistrationRepository userRepository;
+    private final RegistrationRepository userRepository;
 
     public UserDetailsServiceImpl(RegistrationRepository userRepository) {
         this.userRepository = userRepository;

src/main/java/com/dccorp/urlshortner/service/ShortnerService.java

@@ -6,6 +6,7 @@
 import com.dccorp.urlshortner.entity.UrlCodeMappingEntity;
 import com.dccorp.urlshortner.repository.CodeActiveRepository;
 import com.dccorp.urlshortner.repository.URLCodeRepository;
+import com.dccorp.urlshortner.util.AppUtility;
 
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.security.core.Authentication;
@@ -28,18 +29,17 @@ public ShortnerService(URLCodeRepository codeRepository, CodeActiveRepository co
         this.codeRepository = codeRepository;
         this.codeActiveRepository = codeActiveRepository;
     }
-
-
-
+
     public ServiceResponse createShortCode(ServiceRequest serviceRequest) {
         UrlCodeMappingEntity urlCodeMapping = new UrlCodeMappingEntity();
         urlCodeMapping.setCode(serviceRequest.getRequestedShortCode());
         urlCodeMapping.setUrl(serviceRequest.getRequestURL());
         urlCodeMapping.setCreatedDate((LocalDateTime.now()));
         urlCodeMapping.setUpdatedDate((LocalDateTime.now()));
-        Authentication authentication = SecurityContextHolder.getContext().getAuthentication();
-        String currentPrincipalName = authentication.getName();
-        urlCodeMapping.setRequestedBy(currentPrincipalName);
+
+        AppUtility ctx = () -> SecurityContextHolder.getContext().getAuthentication().getName();
+
+        urlCodeMapping.setRequestedBy(ctx.fetchUserFrmCtx());
         UrlCodeMappingEntity codeMappingEntityResponse = codeRepository.save(urlCodeMapping);
 
         CodeActiveEntity codeActiveEntity = new CodeActiveEntity();

src/main/java/com/dccorp/urlshortner/util/AppUtility.java

@@ -3,11 +3,5 @@
 @FunctionalInterface
 public interface AppUtility {
 
-    void printLog(String logString);
-
-    default String provideDefFuntionality()
-    {
-        System.out.println("providing provideDefFuntionality");
-        return "provideDefFuntionality";
-    }
+    String fetchUserFrmCtx();
 }