-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstract hint service #106
Conversation
# Conflicts: # Example/TextFieldsCatalogExample/TextFields/Types and presets/Presets/UnderlinedFieldPreset.swift
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Огонь
*/ | ||
case elastic(minHeight: CGFloat, bottomSpace: CGFloat, ignoreEmptyHint: Bool) | ||
case elastic(policy: FlexibleHeightPolicy) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Вообще как то усложнилась логика - мы в elastic policy указываем flexible policy...
И вызов стал тяжелее
.elastic(policy: .init(minHeight: 77, bottomOffset: 5, ignoreEmptyHint: false))
Но это вкусовщина и ничего лучше я предложить не могу :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
понял, погляжу, но скорее всего тоже ничего предложить не смогу :(
Что сделано
На что обратить внимание
Как протестировать