Update Ray.py Adding 3D point ray with evenly spaced rays to more accurately represent a physical point source. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added spherical rays which are evenly distributed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because I wanted to be able to determine the amount of light that exits a lightguide, which is fed by a LED, I needed a 3d point source with evenly spaced rays. This is important since each ray then represents an equal amount of radiation energy.
The current 3d ray does not provide this. As I showed in on the FreeCAD Forum:
https://forum.freecadweb.org/viewtopic.php?f=8&t=59860&sid=c0e696d6f9f03e9f4185dd6419b78715&start=110
By implementing a paper from the Max-Planck-Institut I managed to create a 3d ray cloud with evenly spaced rays.
link to paper
In this pull request I would like to provide the improved 3d point ray to the Main developers and to the FreeCAD Community.
Since I'm not a programmer by training, my code might be not up to the desired standard, if so let it be an inspriration to improve it furter.
Please let me know what you think of it.