Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash bug on Notepad++ v7.9 #37

Merged
merged 1 commit into from
Sep 20, 2020
Merged

Fix crash bug on Notepad++ v7.9 #37

merged 1 commit into from
Sep 20, 2020

Conversation

donho
Copy link
Contributor

@donho donho commented Sep 16, 2020

In Notepad++ v7.9, the shorcut of command IDM_EDIT_INS_TAB has been removed, whereas the function GetShortCuts() expected a shortcut from this command. This fix makes it work on 2 cases (with or without shorcut).

Fix #36

In Notepad++ v7.9, the shorcut of command IDM_EDIT_INS_TAB has been removed, whereas the function GetShortCuts() expected a shortcut from this command. This fix makes it work on 2 cases (with or without shorcut).

Fix chcg#36
@donho
Copy link
Contributor Author

donho commented Sep 16, 2020

CodeQL / Analyze (pull_request) Failing after 1m — Analyze

@chcg I have no idea about the error, could you enlight me what's the problem?

@chcg
Copy link
Owner

chcg commented Sep 18, 2020

CodeQL / Analyze (pull_request) Failing after 1m — Analyze

@chcg I have no idea about the error, could you enlight me what's the problem?

Started to test https://github.com/github/codeql, not yet configured to work.

@donho
Copy link
Contributor Author

donho commented Sep 18, 2020

@chcg
OK. Thank you for the reply.
So could you merge the fix and release a new version of HexEdit please?

Also, why not point HexEdit in PluginList (https://github.com/notepad-plus-plus/nppPluginList) to the releases here ?

@donho
Copy link
Contributor Author

donho commented Sep 20, 2020

@chcg
Sorry for the bothering: I can see this PR is marked as Merged with info chcg merged 1 commit into chcg:master from donho:patch-1 4 hours ago, however when I check in the master, nothing has been changed. I cannot see either the fix in the commit history... Could you check if this PR is committed into master please?

@chcg
Copy link
Owner

chcg commented Sep 20, 2020

@donho Seems the merge got lost by some of my commit I think. I will correct that again.

chcg added a commit that referenced this pull request Sep 20, 2020
@donho
Copy link
Contributor Author

donho commented Sep 20, 2020

OK. No need to get my branch back.
Please commit it directly - just use pSc = _tcsstr(text, _T("\t")); instead of pSc = &(_tcsstr(text, _T("\t")))[1];
BTW, could you do a release with both 32/64 bit and point HedEdit in nppPluginList to your release?
I will do 7.9 RC2 soon to include the newest nppPluginList so if users complain about the problem of HexEdit in v7.9, we can just tell them to update the latest HexEdit by using PluginAdmin.

@chcg
Copy link
Owner

chcg commented Sep 20, 2020

@donho

@donho
Copy link
Contributor Author

donho commented Sep 20, 2020

@chcg

Thank you very much!

@chcg chcg added this to the 0.9.7 milestone Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HexEdit crash on Notepad++ v7.9
2 participants