Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor flags and subcommands #4

Closed
chclaus opened this issue May 10, 2018 · 0 comments
Closed

Refactor flags and subcommands #4

chclaus opened this issue May 10, 2018 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@chclaus
Copy link
Owner

chclaus commented May 10, 2018

During the development process of dt the commands weren't designed consistently. An example:

The base64 command has four subcommands which defines the used algorithm. Each subcommand accepts a flag to determine if the value should be encoded or decoded. Furthermore there is a flag to pass a string that should be encoded or decoded.

In my eyes, a command or subcommand should do a task and the flags should be used to pass configure options for that tasks.

Given that idea, the base64 command works totally contrary to it.

In this task the whole set of commands and sets should be refactored to allow a cleaner API. That also means, that we have breaking changes and that will lead us to a new major version number. 🎉

@chclaus chclaus added the enhancement New feature or request label May 10, 2018
@chclaus chclaus added this to the 1.0.0 milestone May 10, 2018
@chclaus chclaus self-assigned this May 10, 2018
chclaus added a commit that referenced this issue May 10, 2018
chclaus added a commit that referenced this issue May 10, 2018
chclaus added a commit that referenced this issue May 10, 2018
chclaus added a commit that referenced this issue May 10, 2018
chclaus added a commit that referenced this issue May 10, 2018
chclaus added a commit that referenced this issue May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant