Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try import pyarrow and pandas when necessary #13

Merged
merged 6 commits into from
Apr 18, 2023
Merged

Conversation

auxten
Copy link
Member

@auxten auxten commented Apr 17, 2023

  1. Automatic fix chdb_version = (0, 5, 0) in __init__.py in setup.py
  2. Try importing pyarrow and pandas when necessary, tell user to install them if import error.

@auxten auxten changed the title Fix version in __init__.py Try import pyarrow and pandas when necessary Apr 17, 2023
@auxten auxten linked an issue Apr 17, 2023 that may be closed by this pull request
@auxten auxten merged commit 028329b into pybind Apr 18, 2023
@lmangani
Copy link
Contributor

latest release runs great on all platforms, and it seems quite fast! I'm running it behind a light API for testing with playground:
image

@auxten
Copy link
Member Author

auxten commented Apr 18, 2023

latest release runs great on all platforms, and it seems quite fast! I'm running it behind a light API for testing with playground: image

Oh, this is really cool. I have never thought chdb could be used this way.

@lmangani
Copy link
Contributor

lmangani commented Apr 18, 2023

I know It's a little backwards because you worked really hard to make this into an in-process library, and this hack turns it back into a pretend server, but its great to test performance and portability in containers against another setup 1:1 with the playground

@lmangani
Copy link
Contributor

Incredibly this bundle runs smoothly on a free fly.io instance 🤯🤯🤯🤯🤯

@nmreadelf nmreadelf deleted the hotfix-pyarrow-dep branch August 31, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pandas dataframe output introduced pyarrow and pandas dependency
2 participants