Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow path in dbapi connect #176

Merged
merged 7 commits into from
Mar 20, 2024
Merged

Allow path in dbapi connect #176

merged 7 commits into from
Mar 20, 2024

Conversation

nevinpuri
Copy link
Contributor

@nevinpuri nevinpuri commented Dec 23, 2023

Just as you can pass a path argument to the dbapi.connect() function (enabling persistency). This will allow similar functionality as the Session api already provides, but using the dbapi.

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Added path parameter to dbapi

Documentation entry for user-facing changes

  • Not sure this requires a documentation entry, but here it is:
    path: the folder path to use for database data on disk.
  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

Just as you can pass a `path` argument to a `Session` (enabling persistency), this will allow the `connect` function to have persistency.
@CLAassistant
Copy link

CLAassistant commented Dec 23, 2023

CLA assistant check
All committers have signed the CLA.

@nevinpuri
Copy link
Contributor Author

Don't merge yet, I just realized this change isn't fully working

@nevinpuri
Copy link
Contributor Author

I've updated all the code. Should work but I haven't tested.

@nevinpuri nevinpuri mentioned this pull request Dec 23, 2023
@auxten
Copy link
Member

auxten commented Jan 7, 2024

Please add tests for your modification.
Also, there is a CLA need to sign.

@nevinpuri
Copy link
Contributor Author

@auxten I have added a test. It all should work now 👍

@auxten
Copy link
Member

auxten commented Mar 20, 2024

Fixing some test issue
organizations-2000000.zip link expired. Just use
organizations-500000.zip

@auxten auxten merged commit 95f7774 into chdb-io:main Mar 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants