Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip library/wheels #99

Merged
merged 1 commit into from
Aug 27, 2023
Merged

Strip library/wheels #99

merged 1 commit into from
Aug 27, 2023

Conversation

lmangani
Copy link
Contributor

As we grow in arch coverage and versions, space matters.

Stripping the library could save 100+ megabytes per release/package and the impact on our ability to troubleshoot should be limited since we can easily rebuild locally as needed or bind this to an ENV variable if required.

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Strip distribution library used by wheels

As we grow in arch coverage and versions, space matters. 

Stripping the library could save 100+ megabytes per release/package and the impact on our ability to troubleshoot should be limited since we can easily rebuild locally as needed or bind this to an ENV variable if required.
@lmangani lmangani requested a review from auxten August 26, 2023 21:40
Copy link
Member

@auxten auxten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, it seems the debug info did not help too much.
Let's strip it!

@auxten auxten marked this pull request as ready for review August 27, 2023 06:46
@auxten auxten merged commit 7054c59 into main Aug 27, 2023
auxten pushed a commit that referenced this pull request Sep 3, 2023
As we grow in arch coverage and versions, space matters. 

Stripping the library could save 100+ megabytes per release/package and the impact on our ability to troubleshoot should be limited since we can easily rebuild locally as needed or bind this to an ENV variable if required.
auxten pushed a commit that referenced this pull request Nov 9, 2023
As we grow in arch coverage and versions, space matters. 

Stripping the library could save 100+ megabytes per release/package and the impact on our ability to troubleshoot should be limited since we can easily rebuild locally as needed or bind this to an ENV variable if required.
auxten pushed a commit that referenced this pull request Dec 8, 2023
As we grow in arch coverage and versions, space matters. 

Stripping the library could save 100+ megabytes per release/package and the impact on our ability to troubleshoot should be limited since we can easily rebuild locally as needed or bind this to an ENV variable if required.
auxten pushed a commit that referenced this pull request Jun 7, 2024
As we grow in arch coverage and versions, space matters. 

Stripping the library could save 100+ megabytes per release/package and the impact on our ability to troubleshoot should be limited since we can easily rebuild locally as needed or bind this to an ENV variable if required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants