Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dependabot's new feature to bump multiple packages at once #844

Closed
Maxim-Mazurok opened this issue Oct 1, 2022 · 4 comments
Closed

Support dependabot's new feature to bump multiple packages at once #844

Maxim-Mazurok opened this issue Oct 1, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@Maxim-Mazurok
Copy link

As you can see in Maxim-Mazurok/google-api-typings-generator#722
It says:

Bumps jest and @types/jest. These dependencies needed to be updated together.

Since the title reads "Bump jest and @types/jest" without mentioning the versions, I assume that kodiak couldn't check the versions:

Dependency upgrade types are parsed from the pull request title and body.

I've been using versions = ["major", "minor", "patch"] now I'm trying to remove this to hopefully force it to skip version check and merge anything from dependabot.
@Maxim-Mazurok Maxim-Mazurok added the bug Something isn't working label Oct 1, 2022
@chdsbd
Copy link
Owner

chdsbd commented Oct 1, 2022

Yeah, we should definitely add support for this. It seems like we could parse the pull request body to find the version information.

@Maxim-Mazurok
Copy link
Author

Yeah, we should definitely add support for this. It seems like we could parse the pull request body to find the version information.

Removing the versions field didn't help to get it auto-merged.

I've set up action-add-labels to add automerge for debepdabot PRs as a temporary(?) mesure: https://github.com/Maxim-Mazurok/google-api-typings-generator/blob/master/.github/workflows/add-automerge-label.yml

@sbdchd
Copy link
Collaborator

sbdchd commented Oct 3, 2022

Looking into this, we extract the version from renovate PR descriptions but don't for dependabot. Should be a straightforward fix!

@sbdchd sbdchd mentioned this issue Oct 3, 2022
Merged
kodiakhq bot pushed a commit that referenced this issue Oct 5, 2022
@sbdchd
add(bot): parsing body for dependabot versions (#845)
0ef63b4 
We were parsing version upgrades from the PR title for `dependabot` and `renovatebot`, but we only parsed the body for `renovatebot`.

This PR also parses the body for `dependabot` PRs.


rel: #844
@chdsbd
Copy link
Owner

chdsbd commented Oct 5, 2022

I've deployed #845 which should fix this issue. Let me know if you have any trouble

@chdsbd chdsbd closed this as completed Oct 5, 2022
@Maxim-Mazurok Maxim-Mazurok mentioned this issue Oct 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chdsbd @sbdchd @Maxim-Mazurok