Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete subscriptions from db on cancellation #838

Merged
merged 3 commits into from Jul 28, 2022
Merged

delete subscriptions from db on cancellation #838

merged 3 commits into from Jul 28, 2022

Conversation

chdsbd
Copy link
Owner

@chdsbd chdsbd commented Jul 28, 2022

This helps prevent a Kodiak UI issue where a user still sees a subscription when it's actually cancelled.

@chdsbd chdsbd requested a review from sbdchd July 28, 2022 22:10
@chdsbd chdsbd marked this pull request as ready for review July 28, 2022 22:11
sbdchd
sbdchd approved these changes Jul 28, 2022
View reviewed changes
Copy link
Collaborator

@sbdchd sbdchd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a log statement or something?

@chdsbd chdsbd added the automerge Mark PR for auto merge by Kodiak label Jul 28, 2022
@kodiakhq kodiakhq bot merged commit b29918c into master Jul 28, 2022
@kodiakhq kodiakhq bot deleted the chris/delete-subscriptions-from-db branch July 28, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbdchd sbdchd sbdchd approved these changes

Assignees
No one assigned
Labels
automerge Mark PR for auto merge by Kodiak
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chdsbd @sbdchd