-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix pattern for replacing OPENVSX_URL variable #219
fix: Fix pattern for replacing OPENVSX_URL variable #219
Conversation
Pull Request images published ✨ |
a3bf830
to
9be415c
Compare
Pull Request images published ✨ |
1 similar comment
Pull Request images published ✨ |
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
9be415c
to
981146a
Compare
Pull Request images published ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch 👍
Build 3.7 :: code_3.x/647: Console, Changes, Git Data |
Build 3.7 :: sync-to-downstream_3.x/3381: Console, Changes, Git Data |
Build 3.7 :: get-sources-rhpkg-container-build_3.x/3179: code : 3.x :: |
What does this PR do?
Fixes pattern for replacing
OPENVSX_URL
variable in the/checode/checode-linux-libc/out/vs/workbench/workbench.web.main.js
file.The pattern is used in the entrypoint, see here.
Before this change the pattern broke the corresponding product configuration - it cut all values of the product.json file which were placed after the
serviceUrl
anditemUrl
fields.What issues does this PR fix?
eclipse-che/che#21962
https://issues.redhat.com/browse/CRW-4114
How to test this PR?
I tested it in the downstream:
/checode/checode-linux-libc/out/vs/workbench/workbench.web.main.js
fileextensionsGallery:
The pattern should also handle correctly extra fields in the
extensionGalary
, for example: