Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix pattern for replacing OPENVSX_URL variable #219

Merged

Conversation

RomanNikitenko
Copy link
Contributor

@RomanNikitenko RomanNikitenko commented Apr 28, 2023

What does this PR do?

Fixes pattern for replacing OPENVSX_URL variable in the /checode/checode-linux-libc/out/vs/workbench/workbench.web.main.js file.
The pattern is used in the entrypoint, see here.

Before this change the pattern broke the corresponding product configuration - it cut all values of the product.json file which were placed after the serviceUrl and itemUrl fields.

What issues does this PR fix?

eclipse-che/che#21962
https://issues.redhat.com/browse/CRW-4114

How to test this PR?

I tested it in the downstream:

  • start a workspace
  • open /checode/checode-linux-libc/out/vs/workbench/workbench.web.main.js file
  • search extensionsGallery:
  • check that all fields of the product.json file are present in the file

Screenshot 2023-05-05 at 20 08 54

The pattern should also handle correctly extra fields in the extensionGalary, for example:

"extensionsGallery": {
    "serviceUrl": "https://open-vsx.org/vscode/gallery",
    "itemUrl": "https://open-vsx.org/vscode/item",
    "resourceUrlTemplate": "someResourceUrlTemplate"
  },

@github-actions
Copy link

github-actions bot commented Apr 28, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-219-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-219-dev-amd64

@github-actions
Copy link

github-actions bot commented May 5, 2023

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-219-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-219-dev-amd64

1 similar comment
@github-actions
Copy link

github-actions bot commented May 5, 2023

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-219-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-219-dev-amd64

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@github-actions
Copy link

github-actions bot commented May 8, 2023

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-219-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-219-dev-amd64

Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@RomanNikitenko RomanNikitenko merged commit ea84ef4 into che-incubator:main May 9, 2023
5 checks passed
@RomanNikitenko RomanNikitenko deleted the fixOpenVsxPattern branch May 9, 2023 10:18
@devstudio-release
Copy link

Build 3.7 :: code_3.x/647: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.7 :: get-sources-rhpkg-container-build_3.x/3179: FAILURE

code : 3.x ::
; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants