Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Provide branding for the Welcome page #223

Merged

Conversation

RomanNikitenko
Copy link
Contributor

@RomanNikitenko RomanNikitenko commented May 5, 2023

depends on #219

What does this PR do?

Provides branding for the Welcome page:

  • value of the welcomePageTitle field is used as the Welcome page title
  • value of the nameLong filed is used as the Welcome page title if the welcomePageTitle field is not provided
  • value of the welcomePageSubtitle field is used as the Welcome page subtitle
  • default value from the upstream is used as the Welcome page subtitle if the welcomePageSubtitle field is not provided
  • nameLong is still used for the About dialog and browser tab title
demo.Roman.welcome.page.branding.mp4

What issues does this PR fix?

https://issues.redhat.com/browse/CRW-4114

How to test this PR?

  • provide the corresponding fields to the product.json file
  • build an assembly
  • check that the corresponding changes are applied for the Welcome page

image

@github-actions
Copy link

github-actions bot commented May 5, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented May 5, 2023

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-223-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-223-dev-amd64

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
…'Branding the UI' section

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@RomanNikitenko RomanNikitenko marked this pull request as ready for review May 8, 2023 11:16
@github-actions
Copy link

github-actions bot commented May 8, 2023

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-223-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-223-dev-amd64

@RomanNikitenko RomanNikitenko merged commit 1eaf8da into che-incubator:main May 9, 2023
1 check passed
@RomanNikitenko RomanNikitenko deleted the welcome-page-branding branch May 9, 2023 10:19
@devstudio-release
Copy link

Build 3.7 :: code_3.x/648: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.7 :: get-sources-rhpkg-container-build_3.x/3178: FAILURE

code : 3.x ::
; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants