Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path to templates folder in case of running chectl from installation directory #1090

Merged
merged 2 commits into from
Feb 10, 2021

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Feb 10, 2021

Signed-off-by: Mykola Morhun mmorhun@redhat.com

What does this PR do?

Fixes path to templates folder in case of running chectl from installation directory.
Improves some messages according to suggestions from UX team.

What issues does this PR fix or reference?

eclipse-che/che#19019

How to test this PR?

  1. Build and pack chectl
  2. Install chectl into a folder
  3. Try to deploy Che using the chectl

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Feb 10, 2021

@mmorhun: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/v5-chectl-e2e-operator-installer 7f31312 link /test v5-chectl-e2e-operator-installer

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mmorhun mmorhun merged commit 64ce295 into master Feb 10, 2021
@mmorhun mmorhun deleted the che-18022-1 branch February 10, 2021 10:58
@che-bot che-bot added this to the 7.26 milestone Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants