Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e rollback test #1734

Merged
merged 7 commits into from
Oct 7, 2021
Merged

e2e rollback test #1734

merged 7 commits into from
Oct 7, 2021

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Oct 4, 2021

Signed-off-by: Mykola Morhun mmorhun@redhat.com

What does this PR do?

Adds end to end integration tests for the rollback feature

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

#1680

How to test this PR?

  1. Run minikube
  2. Install OLM
  3. Run yarn test --coverage=false --forceExit --testRegex=test/e2e/e2e-rollback.test.ts

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@mmorhun mmorhun self-assigned this Oct 4, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 4, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2021

Codecov Report

Merging #1734 (54df7db) into main (50a899d) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1734      +/-   ##
==========================================
- Coverage   11.01%   10.97%   -0.04%     
==========================================
  Files          63       63              
  Lines        6836     6858      +22     
  Branches     1173     1174       +1     
==========================================
  Hits          753      753              
- Misses       6083     6105      +22     
Impacted Files Coverage Δ
src/commands/server/restore.ts 0.00% <0.00%> (ø)
src/util.ts 35.86% <0.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50a899d...54df7db. Read the comment docs.

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@mmorhun mmorhun force-pushed the rollback-e2e-tests branch 9 times, most recently from 473803e to 54df7db Compare October 7, 2021 09:55
…eanup.

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@mmorhun mmorhun marked this pull request as ready for review October 7, 2021 10:51
@mmorhun mmorhun changed the title e2e rollback tests draft e2e rollback test Oct 7, 2021
@tolusha tolusha mentioned this pull request Oct 7, 2021
27 tasks
@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorhun, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm label Oct 7, 2021
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm label Oct 7, 2021
@mmorhun mmorhun merged commit fb3f966 into main Oct 7, 2021
@mmorhun mmorhun deleted the rollback-e2e-tests branch October 7, 2021 14:23
@che-bot che-bot added this to the 7.38 milestone Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants