Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minishift-addon): Embed minishift addon #242

Merged
merged 3 commits into from
Aug 9, 2019
Merged

feat(minishift-addon): Embed minishift addon #242

merged 3 commits into from
Aug 9, 2019

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Aug 6, 2019

What does this PR do?

Embed minishift addon into chectl

What issues does this PR fix or reference?

Fix eclipse-che/che#13889
Fix eclipse-che/che#14137
Fix eclipse-che/che#14136

example with an old version of minishift:

$ minishift version
minishift v1.34.0+f5db7cb
$ chectl server:start --installer=minishift-addon --platform=minishift
  ✔ ✈️  Minishift preflight checklist
    ✔ Verify if oc is installed...done.
    ✔ Verify if minishift is installed...done.
    ✔ Verify if minishift is running...done.
    ✔ Retrieving minishift IP and domain for routes URLs...192.168.99.131.nip.io.
  ✔ 🏃‍  Running the Che minishift-addon
    ✔ Check minishift version...done.
    ✔ Check logged...done.
    ✔ Copying addon resources...done.
    ✔ Check che addon is available...done.
    ✔ Apply Che addon...done.
  ✔ ✅  Post installation checklist
    ✔ Che pod bootstrap
      ✔ scheduling...done.
      ✔ downloading images...done.
      ✔ starting...done.
    ✔ Retrieving Che Server URL...http://che-che.192.168.99.131.nip.io
    ✔ Che status check
Command server:start has completed successfully.

And plugin registry is correct

$ oc get dc/che -o json | grep plugin
   "value": "https://che-plugin-registry.openshift.io/v3"

It allows to work with any version of minishift then

Change-Id: I2936be414f33b46acac12581d8d028b8e9342c57
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Fix eclipse-che/che#14137
Chectl was waiting for ever the pod

Change-Id: I0ea89b4496c4728f9044162c6426d7783afdc90c
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
fix eclipse-che/che#14136
Chectl was waiting for ever the pod

Change-Id: I4a1b61104842e9433350fe08444a7fe5165e68de
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@l0rd
Copy link
Collaborator

l0rd commented Aug 7, 2019

@benoitf I see that we are not deploying the registries when the installer is the minishift-addon. That makes sense because the minishift addon doesn't deploy them. But that's still an issue: the version of the registries on osio is an outdated one. We need to update the registries on openshift.io. It should be straightforward for the devfile registries, not sure for the plugin registry cc @ibuziuk

@benoitf
Copy link
Collaborator Author

benoitf commented Aug 7, 2019

@ibuziuk
Copy link
Contributor

ibuziuk commented Aug 7, 2019

It should be straightforward for the devfile registries, not sure for the plugin registry cc @ibuziuk

Looks like nothing should be broken, so I approved the PR with promotion to prod. It is absolutely needed I'm ok to promote it to production now

@l0rd
Copy link
Collaborator

l0rd commented Aug 7, 2019

@benoitf @ibuziuk fantastic. devfile registry should be updated as well.

@ibuziuk
Copy link
Contributor

ibuziuk commented Aug 8, 2019

both plugin and devfile registries have been updated on prod

@benoitf benoitf merged commit 3bed253 into master Aug 9, 2019
@tolusha tolusha deleted the CHE-13889 branch February 5, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants