Update Che plugin registry to the latest state

[benoitf]

Fix eclipse-che/che#14138

Change-Id: I01c47f0bb8c8ee588c239b6bb9fa636af582b790
Signed-off-by: Florent Benoit fbenoit@redhat.com

[centos-ci]

Can one of the admins verify this patch?

[centos-ci]

Can one of the admins verify this patch?

[ibuziuk]

[test]

[ibuziuk]

@benoitf do you happen to know if the latest version of the plugin registry is compatible with the RC 1.1 (the version of che server which is running on prod)?

[benoitf]

It is using which URL ? V3 ?

[ibuziuk]

It is using which URL ? V3 ?

yes v3, but on prod we still not using devfiles and workspace are created based on stacks.json (currently removed from rh-che master) and I suspect this update might break all Che 7 workpaces

[ibuziuk]

@benoitf could we postpone plugin registry update till the GA update of che.openshift.io?
I understand that minishift addon still using it, but I believe if we do update right away it will break prod:

• Update che-plugin-registry to use next che-machine-exec version #1321
• Update plugin registry version #1320

[benoitf]

yes, but predicate In fact a registry instance is deployed with every Che deployment now. is wrong with minishift addon.

[benoitf]

@ibuziuk how it would break stack.json ?

diff is there: eclipse-che/che-plugin-registry@9c87243...master

it only adds new definition of plug-ins and remove v2 and v1 plugins ?

[ibuziuk]

yes, but predicate In fact a registry instance is deployed with every Che deployment now. is wrong with minishift addon.

@benoitf that is correct, but I always thought that we are going to deprecate the addon (if this is not the case I believe we need to make it consistent and deployable with registries).

how it would break stack.json ?

I have not checked this. If it is only v1/v2 cleanup + addition of new plugins (no plugin removals) I believe we can merge it right away

[benoitf]

--> @benoitf that is correct, but I always thought that we are going to deprecate the addon (if this is not the case I believe we need to make it consistent and deployable with registries).

well eclipse-che/che#13889

[centos-ci]

The rh-che test against prod-preview failed.

Link	URL
job log	https://ci.centos.org/job/devtools-saas-openshiftio-pr-check-rh-che/119/console
artifacts	http://artifacts.ci.centos.org/devtools/saas-openshiftio/devtools-saas-openshiftio-pr-check-rh-che/119

Please review the job results and re-run the job by commenting [test] if necessary.

[ibuziuk]

[test]

[ibuziuk]

@benoitf could you please update commit hash to the latest version of the plugin registry ?

[benoitf]

@ibuziuk done

[ibuziuk]

[test]

[ibuziuk]

[test]

[nickboldt]

For what it's worth, this change has broken the ability to launch Che 7 from within CodeReady Workspaces 1.2.1, as the plugins cannot be loaded now.

The related commit in che-plugin-registry: eclipse-che/che-plugin-registry@588cf56

The supported use case in the CRW 1.2 docs:

https://access.redhat.com/documentation/en-us/red_hat_codeready_workspaces/1.2/html-single/administration_guide/index#using-the-che-7-ide-in-codeready-workspaces

The resulting change now required to the CRW 1.2 docs:

https://issues.jboss.org/browse/RHDEVDOCS-1249

So I might argue we should revert this change in che-plugin-registry.openshift.io, and maybe also in in che-plugin-registry... as we're breaking support for existing 1.2 customers.

If a viable workaround can be created, then it's less urgent to revert. But so far the best I've seen is that the workspace CAN be started, though the dashboard is somewhat broken (can't see anything under the Plugins tab).