-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Rework workspace commands to be able to work with user namespace permissions only #849
Conversation
@mmorhun you have failed tests. |
/retest |
1 similar comment
/retest |
…issions only Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Rebased |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Signed-off-by: Mykola Morhun mmorhun@redhat.com
What does this PR do?
All
workspace
commands are reworked in order to be able to work correctly if current user doesn't have permissions to read Che Server namespace. However, in such case we cannot automatically retrieve Che API URL, so it is required from user to provide it in--che-api-endpoint
argument.Also this PR moves all Che API related methods into a separate singleton class.
How to test
The following commands are supposed to be run manually one by one on a CRC cluster with a user which has no permissions for Che Server namespace.
Test commands
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-803