Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deprecate server:start command #909

Merged
merged 4 commits into from
Oct 15, 2020
Merged

feat: Deprecate server:start command #909

merged 4 commits into from
Oct 15, 2020

Conversation

tolusha
Copy link
Collaborator

@tolusha tolusha commented Oct 7, 2020

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

Deprecate server:start command in favor of server:deploy

What issues does this PR fix or reference?

eclipse-che/che#18057

How to test this PR?

  1. Build the project
  2. Run bin/run server:start, check the warning
  3. Run 'bin/run server:deploy` to deploy Eclipse Che

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@AndrienkoAleksandr
Copy link
Contributor

Maybe we should rename src/commands/server/start.ts to deploy.ts?

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha changed the title Deprecate server:start command feat: Deprecate server:start command Oct 15, 2020
@AndrienkoAleksandr
Copy link
Contributor

Tested: after rename start.ts to deploy.ts. Command became broken:

$ ./bin/run server:start -n che -p openshift -m
› Current Kubernetes context: 'che/api-crc-testing:6443/kube:admin'
 ›   Error: command server:start not found

@tolusha to fix it, you need modify a bit code(Rename Start typescript class to the Deploy and change alias):

export default class Deploy extends Command {
  static description = 'start Eclipse Che server'
  static aliases = ['server:start']

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Copy link
Collaborator Author

tolusha commented Oct 15, 2020

/test v4-chectl-e2e

@AndrienkoAleksandr
Copy link
Contributor

Tested both: server:start and server:deploy commands works fine.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, tolusha
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha merged commit e71b2f8 into master Oct 15, 2020
@tolusha tolusha deleted the deprecateserverstart branch October 15, 2020 13:21
@tolusha tolusha mentioned this pull request Oct 21, 2020
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants