-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Deprecate server:start command #909
Conversation
Maybe we should rename src/commands/server/start.ts to deploy.ts? |
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
825be23
to
84cf32f
Compare
Tested: after rename start.ts to deploy.ts. Command became broken: $ ./bin/run server:start -n che -p openshift -m
› Current Kubernetes context: 'che/api-crc-testing:6443/kube:admin'
› Error: command server:start not found @tolusha to fix it, you need modify a bit code(Rename Start typescript class to the Deploy and change alias): export default class Deploy extends Command {
static description = 'start Eclipse Che server'
static aliases = ['server:start'] |
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
/test v4-chectl-e2e |
Tested both: server:start and server:deploy commands works fine. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Anatolii Bazko abazko@redhat.com
What does this PR do?
Deprecate server:start command in favor of server:deploy
What issues does this PR fix or reference?
eclipse-che/che#18057
How to test this PR?
bin/run server:start
, check the warningPR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.