feat: Deprecate server:start command

.vscode/launch.json

@@ -16,7 +16,7 @@
           "name": "Debug Openshift Install",
           "program": "${workspaceFolder}/bin/run",
           "args": [
-              "server:start",
+              "server:deploy",
               "--platform",
               "openshift",
               "--installer",

.vscode/tasks.json

@@ -3,7 +3,7 @@
     "tasks": [
         {
             "label": "Custom che-operator Minikube",
-            "command": "./bin/run server:start -n che -m -p minikube --che-operator-image=${IMAGE_REGISTRY_HOST}/${IMAGE_REGISTRY_USER_NAME}/che-operator:nightly --cheimage=${IMAGE_REGISTRY_HOST}/${IMAGE_REGISTRY_USER_NAME}/che-server:nightly",
+            "command": "./bin/run server:deploy -n che -m -p minikube --che-operator-image=${IMAGE_REGISTRY_HOST}/${IMAGE_REGISTRY_USER_NAME}/che-operator:nightly --cheimage=${IMAGE_REGISTRY_HOST}/${IMAGE_REGISTRY_USER_NAME}/che-server:nightly",
             "type": "shell",
             "args": [],
             "problemMatcher": [
@@ -16,7 +16,7 @@
         },
         {
             "label": "Custom che-operator and che-server Minikube",
-            "command": "./bin/run server:start -n che -m -p minikube --che-operator-image=${IMAGE_REGISTRY_HOST}/${IMAGE_REGISTRY_USER_NAME}/che-operator:nightly --cheimage=${IMAGE_REGISTRY_HOST}/${IMAGE_REGISTRY_USER_NAME}/che-server:nightly",
+            "command": "./bin/run server:deploy -n che -m -p minikube --che-operator-image=${IMAGE_REGISTRY_HOST}/${IMAGE_REGISTRY_USER_NAME}/che-operator:nightly --cheimage=${IMAGE_REGISTRY_HOST}/${IMAGE_REGISTRY_USER_NAME}/che-server:nightly",
             "type": "shell",
             "args": [],
             "problemMatcher": [
@@ -29,7 +29,7 @@
         },
         {
             "label": "Custom che-operator Openshift",
-            "command": "./bin/run server:start -n che -m -p openshift -a operator --che-operator-image=${IMAGE_REGISTRY_HOST}/${IMAGE_REGISTRY_USER_NAME}/che-operator:nightly",
+            "command": "./bin/run server:deploy -n che -m -p openshift -a operator --che-operator-image=${IMAGE_REGISTRY_HOST}/${IMAGE_REGISTRY_USER_NAME}/che-operator:nightly",
             "type": "shell",
             "args": [],
             "problemMatcher": [
@@ -42,7 +42,7 @@
         },
         {
             "label": "Custom che-operator and che-server Openshift",
-            "command": "./bin/run server:start -n che -m -p openshift -a operator --che-operator-image=${IMAGE_REGISTRY_HOST}/${IMAGE_REGISTRY_USER_NAME}/che-operator:nightly --cheimage=${IMAGE_REGISTRY_HOST}/${IMAGE_REGISTRY_USER_NAME}/che-server:nightly",
+            "command": "./bin/run server:deploy -n che -m -p openshift -a operator --che-operator-image=${IMAGE_REGISTRY_HOST}/${IMAGE_REGISTRY_USER_NAME}/che-operator:nightly --cheimage=${IMAGE_REGISTRY_HOST}/${IMAGE_REGISTRY_USER_NAME}/che-server:nightly",
             "type": "shell",
             "args": [],
             "problemMatcher": [

README.md

@@ -88,8 +88,8 @@ USAGE
 * [`chectl help [COMMAND]`](#chectl-help-command)
 * [`chectl server:debug`](#chectl-serverdebug)
 * [`chectl server:delete`](#chectl-serverdelete)
+* [`chectl server:deploy`](#chectl-serverdeploy)
 * [`chectl server:logs`](#chectl-serverlogs)
-* [`chectl server:start`](#chectl-serverstart)
 * [`chectl server:status`](#chectl-serverstatus)
 * [`chectl server:stop`](#chectl-serverstop)
 * [`chectl server:update`](#chectl-serverupdate)
@@ -277,37 +277,13 @@ OPTIONS
 
 _See code: [src/commands/server/delete.ts](https://github.com/che-incubator/chectl/blob/v0.0.2/src/commands/server/delete.ts)_
 
-## `chectl server:logs`
-
-Collect Eclipse Che logs
-
-```
-USAGE
-  $ chectl server:logs
-
-OPTIONS
-  -d, --directory=directory                Directory to store logs into
-  -h, --help                               show CLI help
-
-  -n, --chenamespace=chenamespace          [default: che] Kubernetes namespace where Eclipse Che server is supposed to
-                                           be deployed
-
-  --deployment-name=deployment-name        [default: che] Eclipse Che deployment name
-
-  --listr-renderer=default|silent|verbose  [default: default] Listr renderer
-
-  --skip-kubernetes-health-check           Skip Kubernetes health check
-```
-
-_See code: [src/commands/server/logs.ts](https://github.com/che-incubator/chectl/blob/v0.0.2/src/commands/server/logs.ts)_
-
-## `chectl server:start`
+## `chectl server:deploy`
 
 start Eclipse Che server
 
 ```
 USAGE
-  $ chectl server:start
+  $ chectl server:deploy
 
 OPTIONS
   -a, --installer=helm|operator|olm|minishift-addon
@@ -455,14 +431,41 @@ OPTIONS
       the latest known version.
                            This parameter is used only when the installer is 'olm'.
 
-  --workspace-engine=legacy|dev-workspace
-      [default: legacy] Workspace Engine. If not set, default is "legacy". "dev-workspace" is experimental.
+  --workspace-engine=che-server|dev-workspace
+      [default: che-server] Workspace Engine. If not set, default is "che-server". "dev-workspace" is experimental.
 
   --workspace-pvc-storage-class-name=workspace-pvc-storage-class-name
       persistent volume(s) storage class name to use to store Eclipse Che workspaces data
+
+ALIASES
+  $ chectl server:start
 ```
 
-_See code: [src/commands/server/start.ts](https://github.com/che-incubator/chectl/blob/v0.0.2/src/commands/server/start.ts)_
+_See code: [src/commands/server/deploy.ts](https://github.com/che-incubator/chectl/blob/v0.0.2/src/commands/server/deploy.ts)_
+
+## `chectl server:logs`
+
+Collect Eclipse Che logs
+
+```
+USAGE
+  $ chectl server:logs
+
+OPTIONS
+  -d, --directory=directory                Directory to store logs into
+  -h, --help                               show CLI help
+
+  -n, --chenamespace=chenamespace          [default: che] Kubernetes namespace where Eclipse Che server is supposed to
+                                           be deployed
+
+  --deployment-name=deployment-name        [default: che] Eclipse Che deployment name
+
+  --listr-renderer=default|silent|verbose  [default: default] Listr renderer
+
+  --skip-kubernetes-health-check           Skip Kubernetes health check
+```
+
+_See code: [src/commands/server/logs.ts](https://github.com/che-incubator/chectl/blob/v0.0.2/src/commands/server/logs.ts)_
 
 ## `chectl server:status`
 

src/commands/server/start.ts → src/commands/server/deploy.ts

@@ -30,8 +30,9 @@ import { CommonPlatformTasks } from '../../tasks/platforms/common-platform-tasks
 import { PlatformTasks } from '../../tasks/platforms/platform'
 import { getCommandSuccessMessage, initializeContext, isOpenshiftPlatformFamily } from '../../util'
 
-export default class Start extends Command {
+export default class Deploy extends Command {
   static description = 'start Eclipse Che server'
+  static aliases = ['server:start']
 
   static flags: flags.Input<any> = {
     help: flags.help({ char: 'h' }),
@@ -342,7 +343,11 @@ export default class Start extends Command {
   }
 
   async run() {
-    const { flags } = this.parse(Start)
+    if (process.argv.indexOf('server:start')) {
+      this.warn('\'server:start\' command is deprecated. Use \'server:deploy\' instead.')
+    }
+
+    const { flags } = this.parse(Deploy)
     const ctx = initializeContext()
     ctx.directory = path.resolve(flags.directory ? flags.directory : path.resolve(os.tmpdir(), 'chectl-logs', Date.now().toString()))
     const listrOptions: Listr.ListrOptions = { renderer: (flags['listr-renderer'] as any), collapse: false, showSubtasks: true } as Listr.ListrOptions

src/commands/server/update.ts

@@ -131,7 +131,7 @@ export default class Update extends Command {
       await preInstallTasks.run(ctx)
 
       if (!ctx.isCheDeployed) {
-        this.error('Eclipse Che deployment is not found. Use `chectl server:start` to initiate a new deployment.')
+        this.error('Eclipse Che deployment is not found. Use `chectl server:deploy` to initiate a new deployment.')
       } else {
         if (isKubernetesPlatformFamily(flags.platform!)) {
           await this.setDomainFlag(flags)

test/e2e/minikube.test.ts

@@ -18,11 +18,11 @@ const PLATFORM = 'kubernetes'
 const binChectl = `${process.cwd()}/bin/run`
 
 describe('Eclipse Che deploy test suite', () => {
-  describe('server:start using operator and self signed certificates', () => {
+  describe('server:deploy using operator and self signed certificates', () => {
     test
       .stdout({ print: true })
       .stderr({ print: true })
-      .command(['server:start', '--platform=minikube', '--che-operator-cr-patch-yaml=test/e2e/util/cr-test.yaml', '--tls', '--installer=operator', '--skip-cluster-availability-check'])
+      .command(['server:deploy', '--platform=minikube', '--che-operator-cr-patch-yaml=test/e2e/util/cr-test.yaml', '--tls', '--installer=operator', '--skip-cluster-availability-check'])
       .exit(0)
       .it('uses minikube as platform, operator as installer and auth is enabled')
     test

test/e2e/minishift.test.ts

@@ -19,9 +19,9 @@ const PLATFORM = 'openshift'
 const binChectl = `${process.cwd()}/bin/run`
 
 describe('Eclipse Che deploy test suite', () => {
-  describe('server:start using operator and self signed certificates', () => {
-    it('server:start using operator and self signed certificates', async () => {
-      const command = `${binChectl} server:start --platform=minishift --che-operator-cr-patch-yaml=test/e2e/util/cr-test.yaml --tls --installer=operator`
+  describe('server:deploy using operator and self signed certificates', () => {
+    it('server:deploy using operator and self signed certificates', async () => {
+      const command = `${binChectl} server:deploy --platform=minishift --che-operator-cr-patch-yaml=test/e2e/util/cr-test.yaml --tls --installer=operator`
       const { exitCode, stdout, stderr } = await execa(command, { shell: true })
 
       expect(exitCode).equal(0)

test/e2e/openshift.test.ts

@@ -19,9 +19,9 @@ const PLATFORM = 'openshift'
 const binChectl = `${process.cwd()}/bin/run`
 
 describe('Eclipse Che deploy test suite', () => {
-  describe('server:start using operator and self signed certificates', () => {
-    it('server:start using operator and self signed certificates', async () => {
-      const command = `${binChectl} server:start --platform=${PLATFORM} --che-operator-cr-patch-yaml=test/e2e/util/cr-test.yaml --tls --installer=operator`
+  describe('server:deploy using operator and self signed certificates', () => {
+    it('server:deploy using operator and self signed certificates', async () => {
+      const command = `${binChectl} server:deploy --platform=${PLATFORM} --che-operator-cr-patch-yaml=test/e2e/util/cr-test.yaml --tls --installer=operator`
       const { exitCode, stdout, stderr } = await execa(command, { shell: true })
 
       expect(exitCode).equal(0)

yarn.lock

@@ -2094,19 +2094,19 @@ ecc-jsbn@~0.1.1:
 
 "eclipse-che-devfile-workspace-operator@git://github.com/devfile/devworkspace-operator#master":
   version "0.0.0"
-  resolved "git://github.com/devfile/devworkspace-operator#27dc45b83bd235789d72aee2cac4ac8f79ed430d"
+  resolved "git://github.com/devfile/devworkspace-operator#4ea0394233e7b90a3512a4e1323eb25590309ff3"
 
 "eclipse-che-minishift@git://github.com/minishift/minishift#master":
   version "0.0.0"
   resolved "git://github.com/minishift/minishift#4b58f8954421fcbb7996ca67cba7ed8c58092a88"
 
 "eclipse-che-operator@git://github.com/eclipse/che-operator#master":
   version "0.0.0"
-  resolved "git://github.com/eclipse/che-operator#c5ab66b099d6ae64a7aafb856fa9da3c7d6c3a7a"
+  resolved "git://github.com/eclipse/che-operator#227046459c196fe8b95fd66a444a69808cac97e3"
 
 "eclipse-che@git://github.com/eclipse/che#master":
   version "0.0.0"
-  resolved "git://github.com/eclipse/che#695e6bddd33bd8081c008a70603439e8623fb522"
+  resolved "git://github.com/eclipse/che#00591be5ff0cd25d7dbf340adb419cae64e2f060"
 
 editorconfig@^0.15.0:
   version "0.15.3"