This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Support for deploy directory to be consumed by chectl #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "meat" is in the Makefile and the deploy/generate-deployment.sh script, and the deploy/templates kustomize declarations. the deploy/deployment directory is generated but needs to be in the source control so that chectl can directly consume it. Also adding a github action on PRs to make sure all the generated files are up-to-date before merging.
on workspace routings.
later reuse it for a more detailed progress reporting in chectl.
FORCE_CRD_UPDATES from the deployment generating script.
sparkoo
approved these changes
Feb 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Support for deploy directory to be consumed by chectl.
The "meat" is in the Makefile and the deploy/generate-deployment.sh script,
and the deploy/templates kustomize declarations.
the deploy/deployment directory is generated but needs to be in the source
control so that chectl can directly consume it.
Also adding a github action on PRs to make sure all the generated files are
up-to-date before merging.
What issues does this PR fix or reference?
eclipse-che/che#19001