Use NaN data for the dummy plot in chebfun.plot(). #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we just replotted the existing line data and set the plot's "Visible" property to 'off'. This doesn't work properly anymore in R2016b, since MATLAB grays out the legend entries for graphics items marked invisible. The fix is easy enough: we plot NaN data for the dummy plot (but set the line and point styles appropriately) and leave "Visible" set to 'on'. MATLAB doesn't draw anything on the plot for NaN data, so we're good. A little ugly, but we already use this trick elsewhere for other things. Closes #2061.
|
Thanks @aaustin141 , the fix seems to work fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we just replotted the existing line data and set the plot's
"Visible" property to 'off'. This doesn't work properly anymore in
R2016b, since MATLAB grays out the legend entries for graphics items
marked invisible.
The fix is easy enough: we plot NaN data for the dummy plot (but set
the line and point styles appropriately) and leave "Visible" set to
'on'. MATLAB doesn't draw anything on the plot for NaN data, so we're
good. A little ugly, but we already use this trick elsewhere for other
things.
Closes #2061.