Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for playwright config on browser checks #907

Merged
merged 2 commits into from
Dec 20, 2023
Merged

feat: add support for playwright config on browser checks #907

merged 2 commits into from
Dec 20, 2023

Conversation

ferrandiaz
Copy link
Contributor

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

Add support for playwright config on browser check
Used RFC as reference for parameters supported

@shortcut-integration Shortcut Integration
Copy link

This pull request has been linked to Shortcut Story #18570: As a user, I would like to use pwt config use field configurations in my checks.

umutuzgur
umutuzgur approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@umutuzgur umutuzgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ferrandiaz ferrandiaz merged commit c690d1d into main Dec 20, 2023
3 checks passed
@ferrandiaz ferrandiaz deleted the ferran/sc-18570/pwt-config branch December 20, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umutuzgur umutuzgur umutuzgur approved these changes

@clample clample Awaiting requested review from clample

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ferrandiaz @umutuzgur