Fixed token leaks #1364
Merged
Fixed token leaks #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
Comment on lines
96
to
99
| <maskPattern>https://([_a-zA-Z0-9]+)@github.com</maskPattern> | ||
| <maskPattern>https://([_a-zA-Z0-9]+)@dev.azure.com</maskPattern> | ||
| <maskPattern>https://([_a-zA-Z0-9:.\\-]+)@bitbucket.org</maskPattern> | ||
| <maskPattern>https://([_a-zA-Z0-9:.\\-]+)@gitlab.com</maskPattern> |
There was a problem hiding this comment.
I'd suggest you generalize this, currently it doesn't support self-hosted instances, plus I don't think there is a single web site where you'd want to show the authentication token anyway
<maskPattern>https://([_a-zA-Z0-9:.\\-]+|)@.+</maskPattern>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed token leaks for GitLab Issues and also masked token values for SCM GitLab, ADO, Bitbucket
References
#1341
Testing
Tested for SCM GitHub GitLab ADO and Bitbucket