feat(crit): add crit x sk for sockets
#138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #138 +/- ##
==========================================
- Coverage 50.48% 49.49% -0.99%
==========================================
Files 24 24
Lines 2601 2760 +159
==========================================
+ Hits 1313 1366 +53
- Misses 1104 1203 +99
- Partials 184 191 +7
☔ View full report in Codecov by Sentry. |
rst0git
reviewed
Jul 20, 2023
snprajwal
force-pushed
the
explore-sk
branch
2 times, most recently
from
74a5040
to
81f1b7c
Compare
rst0git
reviewed
Aug 1, 2023
snprajwal
force-pushed
the
explore-sk
branch
2 times, most recently
from
c24d39f
to
5ee0454
Compare
rst0git
reviewed
Aug 2, 2023
rst0git
reviewed
Aug 3, 2023
rst0git
reviewed
Aug 3, 2023
rst0git
reviewed
Aug 3, 2023
The options for `crit x` were using mix of plural and singular forms. This now fixes it to use singular only. Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
The `countBytes()` utility was using SCREAMING_SNAKE_CASE for constants. This has now been changed to use camelCase as per the Go convention. Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
Using `crit x fd` to list file descriptors now skips processes that have no associated FDs. Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
snprajwal
force-pushed
the
explore-sk
branch
2 times, most recently
from
179c833
to
0c11d9c
Compare
rst0git
reviewed
Aug 4, 2023
Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for implementing socket views in checkpointctl, going forward.