Optimize stats and rpc #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpc.proto is not an image. It is a protocol that enables RPC communication with criu-service. Moving rpc in separate package allow us to avoid importing unnecessary dependencies. Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
We recently introduced support for CRIT in go-criu. However, the linker in the Go toolchain creates statically-linked binaries, including the Go runtime and other information necessary to support dynamic type checks. As a result, when updating Podman to use the latest go-criu version, the auto-generated protobuf binding for all CRIU images are compiled into the Podman binary, significantly increasing its size. Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
|
cc @snprajwal |
snprajwal
reviewed
Oct 6, 2022
adrianreber
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently introduced support for CRIT in go-criu. However, the linker in the Go toolchain creates statically-linked binaries, including the Go runtime and other information necessary to support dynamic type checks. As a result, when updating Podman to use the latest go-criu version, the auto-generated protobuf binding for all CRIU images are compiled into the Podman binary, significantly increasing its size.
This pull request partially reverts the changes in #87 to allow us to upgrade go-criu without increasing the size of the compiled binaries.