Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for violation N lines above/below in Inline Config Parser #10752

Closed
shashwatj07 opened this issue Aug 29, 2021 · 2 comments · Fixed by #10989
Closed

Add support for violation N lines above/below in Inline Config Parser #10752

shashwatj07 opened this issue Aug 29, 2021 · 2 comments · Fixed by #10989
Labels
approved miscellaneous
Milestone
9.2.1

Comments

@shashwatj07
Copy link
Contributor

inspired from #10692 (comment)
@Vyom-Yadav
Copy link
Member

on it.

Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Nov 28, 2021
@Vyom-Yadav
Issue checkstyle#10752: Added support for violation N lines above/bel…
71130ab 
…ow in Inline Config Parser
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Nov 28, 2021
@Vyom-Yadav
Issue checkstyle#10752: Added support for violation N lines above/bel…
6a097e1 
…ow in Inline Config Parser
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Nov 28, 2021
@Vyom-Yadav
Issue checkstyle#10752: Added support for violation N lines above/bel…
d3cd566 
…ow in Inline Config Parser
@Vyom-Yadav Vyom-Yadav mentioned this issue Nov 28, 2021
Merged
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Nov 28, 2021
@Vyom-Yadav
Issue checkstyle#10752: Added support for violation N lines above/bel…
9a62f78 
…ow in Inline Config Parser
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Nov 29, 2021
@Vyom-Yadav
Issue checkstyle#10752: Added support for violation N lines above/bel…
706b4d3 
…ow in Inline Config Parser
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Dec 1, 2021
@Vyom-Yadav
Issue checkstyle#10752: Added support for violation N lines above/bel…
7d883d9 
…ow in Inline Config Parser
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Dec 1, 2021
@Vyom-Yadav
minor: extracting method in InlineConfigParser for future extension i…
496238c 
…n Issue checkstyle#10752
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Dec 1, 2021
@Vyom-Yadav
Issue checkstyle#10752: Added support for violation N lines above/bel…
665e283 
…ow in Inline Config Parser
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Dec 1, 2021
@Vyom-Yadav
Issue checkstyle#10752: Added support for violation N lines above/bel…
1d27f2d 
…ow in Inline Config Parser and migrated to Inline Config Parser in NonEmptyAtclauseDescriptionCheckTest
@Vyom-Yadav Vyom-Yadav mentioned this issue Dec 9, 2021
Closed
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Dec 9, 2021
@Vyom-Yadav
minor: extracting method in InlineConfigParser for future extension i…
c8deeb0 
…n Issue checkstyle#10752
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Dec 9, 2021
@Vyom-Yadav
Issue checkstyle#10752: Added support for violation N lines above/bel…
42050d8 
…ow in Inline Config Parser and migrated to Inline Config Parser in NonEmptyAtclauseDescriptionCheckTest
rnveach pushed a commit that referenced this issue Dec 9, 2021
@Vyom-Yadav @rnveach
minor: extracting method in InlineConfigParser for future extension i…
defd358 
…n Issue #10752
rnveach pushed a commit that referenced this issue Dec 9, 2021
@Vyom-Yadav @rnveach
Issue #10752: Added support for violation N lines above/below in Inli…
e4cf277 
…ne Config Parser and migrated to Inline Config Parser in NonEmptyAtclauseDescriptionCheckTest
@rnveach
Copy link
Member

rnveach commented Dec 9, 2021

Fix was merged.

@rnveach rnveach added this to the 9.3 milestone Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved miscellaneous
Projects
None yet
Milestone
9.2.1
4 participants
@romani @rnveach @shashwatj07 @Vyom-Yadav