Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix methods for package-info file check #11531

Closed
strkkk opened this issue Apr 10, 2022 · 3 comments
Closed

Fix methods for package-info file check #11531

strkkk opened this issue Apr 10, 2022 · 3 comments
Labels
approved miscellaneous
Milestone
10.3

Comments

@strkkk
Copy link
Member

strkkk commented Apr 10, 2022

Current implementation of FileContents looks like

checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/api/FileContents.java

Lines 332 to 334 in 5df2e3f

public boolean inPackageInfo() {
return getFileName().endsWith("package-info.java");
}

It will return true on inputs like some-package-info.java

It should be fixed. Also after #11502 replacement method CheckUtil#isPackageInfo should be fixed as well.
@strkkk strkkk mentioned this issue Apr 10, 2022
Merged
@strkkk strkkk changed the title Fix CheckUtil#isPackageInfo method Fix methods for package-info file check Apr 10, 2022
@TaiweiHu
Copy link
Contributor

I would like to work on this issue.

@strkkk
Copy link
Member Author

strkkk commented Apr 12, 2022

@RandyLovevivi PR is welcome. Please note that after merge of #11531 CheckUtil#isPackageInfo should be fixed as well

@checkstyle checkstyle deleted a comment from adinayyu Apr 15, 2022
@checkstyle checkstyle deleted a comment from adinayyu Apr 15, 2022
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 19, 2022
@as23415672
Issue checkstyle#11531
262dbec 
Fixed the issue by checking if the string is ended with "package-info.java" and the substring except the last 17 letters ( which is the length of "package-info.java" ) ends with "\" or ".".
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 19, 2022
@as23415672
Revert "Issue checkstyle#11531"
8c9513a 
This reverts commit 262dbec.
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 19, 2022
@as23415672
Issue checkstyle#11531: Fixed the methods for package-info file check
17eca00 
Fixed the issue by checking if the string is ended with "package-info.java" and the substring except the last 17 letters ( which is the length of "package-info.java" ) ends with "\" or ".".
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 19, 2022
@as23415672
Issue checkstyle#11531: Fixed the methods for package-info file check
99221f1 
Fixed the issue by checking if the string is ended with "package-info.java" and the substring except the last 17 letters ( which is the length of "package-info.java" ) ends with "\" or ".".
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 19, 2022
@as23415672
Issue checkstyle#11531
08b54fb 
Fixed the issue by checking if the string is ended with "package-info.java" and the substring except the last 17 letters ( which is the length of "package-info.java" ) ends with "\" or ".".

Revert "Issue checkstyle#11531"

This reverts commit 262dbec.

Issue checkstyle#11531: Fixed the methods for package-info file check

Fixed the issue by checking if the string is ended with "package-info.java" and the substring except the last 17 letters ( which is the length of "package-info.java" ) ends with "\" or ".".

Issue checkstyle#11531: Fixed the methods for package-info file check

Fixed the issue by checking if the string is ended with "package-info.java" and the substring except the last 17 letters ( which is the length of "package-info.java" ) ends with "\" or ".".
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 19, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
f3d3baf 
Fixed the issue by checking if the string is ended with "package-info.java" and the substring except the last 17 letters ( which is the length of "package-info.java" ) ends with "\" or ".".
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 19, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
933f2bf
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 19, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
b9f7f5e
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 19, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
4208d77
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 19, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
14592ee
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 19, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
93a57bd
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 19, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
3ef1717
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 19, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
ce75a8f
@as23415672 as23415672 mentioned this issue Apr 19, 2022
Merged
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 20, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
195d1c7
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 21, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
57e2ed7
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 22, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
7d97bb8
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 22, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
bd12bcf
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 22, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
e7942d1
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 22, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
2e94478
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 22, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
5b4c20c
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 22, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
a551bca
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 22, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
c39491a
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 22, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
9dc5217
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 22, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
47ebd5f
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 22, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
4a42217
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 22, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
5a13a97
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 22, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
05ebb14
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 22, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
9a8ee67
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 22, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
a596742
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 22, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
a60ff37
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 23, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
4a1d9a3
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 23, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
07c119f
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 23, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
1ecc3e3
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 23, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
92e0a26
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 23, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
e5e1ebc
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 23, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
882c550
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 23, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
66cd81c
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 23, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
52df258
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 23, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
37789c6
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 23, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
7ef3eed
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 23, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
0be11f9
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 23, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
07b566d
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 23, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
a6bc58f
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 23, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
9e449a5
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 23, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
19b27ad
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 23, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
a97d164
as23415672 added a commit to cs304-2022/checkstyle that referenced this issue Apr 24, 2022
@as23415672
Issue checkstyle#11531: Fixed methods for package-info file check
054c69f
strkkk pushed a commit that referenced this issue Apr 24, 2022
@as23415672 @strkkk
Issue #11531: Fixed methods for package-info file check
2caf0b6
@strkkk strkkk added this to the 10.3 milestone Apr 24, 2022
@strkkk
Copy link
Member Author

strkkk commented Apr 24, 2022

Fix is merged

@strkkk strkkk closed this as completed Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved miscellaneous
Projects
None yet
Milestone
10.3
Development

No branches or pull requests
3 participants
@romani @strkkk @TaiweiHu