Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweet-releasenotes.sh does not check env variables #11784

Closed
romani opened this issue Jun 27, 2022 · 3 comments
Closed

tweet-releasenotes.sh does not check env variables #11784

romani opened this issue Jun 27, 2022 · 3 comments

Comments

@romani
Copy link
Member

romani commented Jun 27, 2022

✔ ~/java/github/checkstyle/checkstyle [master|✔] 
$ ./.ci/tweet-releasenotes.sh 
fatal: destination path 'contribution' already exists and is not an empty directory.
^C

expected: failure that varaibles are not defined.

@Rahulkhinchi03
Copy link
Contributor

I still think we should use:

checkForVariable() {
  if [[ "$(declare -p "$1")" =~ ^declare\ -x ]]; then
    echo "Error: Define $1 environment variable"
    exit 1
  fi
}

bsdfgb

romani added a commit to romani/checkstyle that referenced this issue Jul 3, 2022
romani added a commit to romani/checkstyle that referenced this issue Jul 3, 2022
romani added a commit to romani/checkstyle that referenced this issue Jul 3, 2022
@romani
Copy link
Member Author

romani commented Jul 3, 2022

@romani romani added this to the 10.4 milestone Jul 3, 2022
@romani
Copy link
Member Author

romani commented Jul 3, 2022

Fix is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants