Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff-Report action does not post link to report in GitHub comment #12794

Closed
Vyom-Yadav opened this issue Mar 4, 2023 · 5 comments · Fixed by #12946
Closed

Diff-Report action does not post link to report in GitHub comment #12794

Vyom-Yadav opened this issue Mar 4, 2023 · 5 comments · Fixed by #12946
Labels
approved CI miscellaneous
Milestone
10.10.0

Comments

@Vyom-Yadav
Copy link
Member

There is no link posted by the GitHub action when using Report label: property.

I suspect that because we append to the message it goes on to the next line and only first line is picked up by upcoming steps or it has something to do with set-output.

Noticed at: #11231 (comment), #11231 (comment)
@Vyom-Yadav Vyom-Yadav mentioned this issue Mar 4, 2023
Closed
4 tasks
@stoyanK7
Copy link
Contributor

stoyanK7 commented Apr 1, 2023

I am on it.

@stoyanK7 stoyanK7 mentioned this issue Apr 1, 2023
Merged
nrmancuso pushed a commit that referenced this issue Apr 4, 2023
@stoyanK7 @nrmancuso
Issue #12794: Diff-Report action does not post link to report in GitH…
9c528c4 
…ub comment
@nrmancuso nrmancuso reopened this Apr 4, 2023
@nrmancuso
Copy link
Member

@stoyanK7 please open a PR based on latest master to test report label and link it here, we can close issue after this test.

@github-actions github-actions bot added this to the 10.9.4 milestone Apr 4, 2023
@stoyanK7 stoyanK7 mentioned this issue Apr 4, 2023
Closed
@stoyanK7
Copy link
Contributor

stoyanK7 commented Apr 4, 2023

@nrmancuso Done at #12955 (comment)

@nrmancuso
Copy link
Member

Closed via #12946

@nrmancuso
Copy link
Member

@stoyanK7 thanks a lot for testing :)

Sloent pushed a commit to Sloent/checkstyle that referenced this issue Apr 18, 2023
@stoyanK7 @Sloent
Issue checkstyle#12794: Diff-Report action does not post link to repo…
6473a0d 
…rt in GitHub comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved CI miscellaneous
Projects
None yet
Milestone
10.10.0
Development

Successfully merging a pull request may close this issue.

Issue #12794: Diff-Report action does not post link to report in GitHub comment
3 participants
@stoyanK7 @nrmancuso @Vyom-Yadav