Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve pitest suppression for BeforeExecutionFileFilterSet #12878

Closed
ThatSneakyCoder opened this issue Mar 21, 2023 · 4 comments
Closed

Resolve pitest suppression for BeforeExecutionFileFilterSet #12878

ThatSneakyCoder opened this issue Mar 21, 2023 · 4 comments
Labels
approved miscellaneous
Milestone
10.9.3

Comments

@ThatSneakyCoder
Copy link
Contributor

Related to #12341

Kill the surviving mutation:

checkstyle/config/pitest-suppressions/pitest-api-suppressions.xml

Lines 21 to 28 in d59b83b

<mutation unstable="false">
<sourceFile>BeforeExecutionFileFilterSet.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.api.BeforeExecutionFileFilterSet</mutatedClass>
<mutatedMethod>toString</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.returns.EmptyObjectReturnValsMutator</mutator>
<description>replaced return value with &quot;&quot; for com/puppycrawl/tools/checkstyle/api/BeforeExecutionFileFilterSet::toString</description>
<lineContent>return beforeExecutionFileFilters.toString();</lineContent>
</mutation>

@ThatSneakyCoder
Copy link
Contributor Author

Please approve.

@ThatSneakyCoder
Copy link
Contributor Author

I'm on it.

ThatSneakyCoder added a commit to ThatSneakyCoder/checkstyle that referenced this issue Mar 22, 2023
@ThatSneakyCoder
Issue checkstyle#12878: Resolve pitest suppression for BeforeExecutio…
f8ce8fe 
…nFileFilterSet
@ThatSneakyCoder ThatSneakyCoder mentioned this issue Mar 22, 2023
Merged
ThatSneakyCoder added a commit to ThatSneakyCoder/checkstyle that referenced this issue Mar 22, 2023
@ThatSneakyCoder
Issue checkstyle#12878: Resolve pitest suppression for BeforeExecutio…
e25fc63 
…nFileFilterSet
ThatSneakyCoder added a commit to ThatSneakyCoder/checkstyle that referenced this issue Mar 22, 2023
@ThatSneakyCoder
Issue checkstyle#12878: Resolve pitest suppression for BeforeExecutio…
2d02616 
…nFileFilterSet
ThatSneakyCoder added a commit to ThatSneakyCoder/checkstyle that referenced this issue Mar 22, 2023
@ThatSneakyCoder
Issue checkstyle#12878: Resolve pitest suppression for BeforeExecutio…
06e66d0 
…nFileFilterSet
@ThatSneakyCoder
Copy link
Contributor Author

@romani
Please note that over here as well I will have to write pure JUnit test case as #12881

I will place the appropriate message wherever required.

ThatSneakyCoder added a commit to ThatSneakyCoder/checkstyle that referenced this issue Mar 22, 2023
@ThatSneakyCoder
Issue checkstyle#12878: Resolve pitest suppression for BeforeExecutio…
54fb322 
…nFileFilterSet
@ThatSneakyCoder ThatSneakyCoder mentioned this issue Mar 22, 2023
Merged
romani pushed a commit that referenced this issue Mar 23, 2023
@ThatSneakyCoder @romani
Issue #12878: Resolve pitest suppression for BeforeExecutionFileFilte…
ad1b81c 
…rSet
ThatSneakyCoder added a commit to ThatSneakyCoder/checkstyle that referenced this issue Mar 23, 2023
@ThatSneakyCoder
Issue checkstyle#12878: Resolve pitest suppression for BeforeExecutio…
12477d6 
…nFileFilterSet
ThatSneakyCoder added a commit to ThatSneakyCoder/checkstyle that referenced this issue Mar 23, 2023
@ThatSneakyCoder
Issue checkstyle#12878: Resolve pitest suppression for BeforeExecutio…
cb21eea 
…nFileFilterSet
ThatSneakyCoder added a commit to ThatSneakyCoder/checkstyle that referenced this issue Mar 23, 2023
@ThatSneakyCoder
Issue checkstyle#12878: Resolve pitest suppression for BeforeExecutio…
277c0d7 
…nFileFilterSet
ThatSneakyCoder added a commit to ThatSneakyCoder/checkstyle that referenced this issue Mar 23, 2023
@ThatSneakyCoder
Issue checkstyle#12878: Resolve pitest suppression for BeforeExecutio…
263ef97 
…nFileFilterSet
nrmancuso pushed a commit that referenced this issue Mar 24, 2023
@ThatSneakyCoder @nrmancuso
Issue #12878: Resolve pitest suppression for BeforeExecutionFileFilte…
c5709fe 
…rSet
@nrmancuso
Copy link
Member

Closed via #12883

@nrmancuso nrmancuso added this to the 10.9.3 milestone Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved miscellaneous
Projects
None yet
Milestone
10.9.3
Development

No branches or pull requests
3 participants
@romani @nrmancuso @ThatSneakyCoder