Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

organize checkstyle_checks.xml #2526

Closed
rnveach opened this issue Nov 4, 2015 · 4 comments
Closed

organize checkstyle_checks.xml #2526

rnveach opened this issue Nov 4, 2015 · 4 comments
Assignees
@rnveach
Labels
approved miscellaneous
Milestone
6.12.1

Comments

@rnveach
Copy link
Member

rnveach commented Nov 4, 2015

Since we removed our reliance on actual line numbers in links, we can now organize checkstyle_checks.xml however we want.

We should have all Checker checks on top, TreeWalker should always be last.
Each check should be grouped by package with a comment on the package above it.
Each group of package should then ordered by check name alphabetically like we do on the "config_XXXXX.html".
@mkordas
Copy link
Contributor

mkordas commented Nov 4, 2015

@rnveach, can I also reopen #2244?

@rnveach
Copy link
Member Author

rnveach commented Nov 4, 2015

@mkordas" xdocs/google_style.xml" still has line links. I will be finishing this soon as part of #2519.
These changes won't go in until we release anyways, so I don't think order matters, but confirm with @romani.

@romani
Copy link
Member

romani commented Nov 4, 2015

We cat make release as soon as we merged your changes.

rnveach added a commit to rnveach/checkstyle that referenced this issue Nov 4, 2015
@rnveach
Issue checkstyle#2526: reorganized checkstyle_checks.xml
64af3ad
rnveach added a commit to rnveach/checkstyle that referenced this issue Nov 4, 2015
@rnveach
Issue checkstyle#2526: reorganized checkstyle_checks.xml
fccfd50
romani pushed a commit that referenced this issue Nov 5, 2015
@rnveach @romani
Issue #2526: reorganized checkstyle_checks.xml
073b452
@romani romani added the approved label Nov 5, 2015
@romani romani added this to the 6.12.1 milestone Nov 5, 2015
@romani
Copy link
Member

romani commented Nov 5, 2015

merged

@romani romani closed this as completed Nov 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rnveach rnveach

Labels
approved miscellaneous
Projects
None yet
Milestone
6.12.1
Development

No branches or pull requests
3 participants
@romani @rnveach @mkordas