XDoc Config: create unit test to verify property types and default values

[rnveach]

For types:

checkstyle/src/xdocs/config_coding.xml

Line 1283 in 20506e1

<td><a href="property_types.html#stringSet">list of strings</a></td>

We interchange Type Set and list of types.

checkstyle/src/xdocs/config_coding.xml

Line 2005 in 20506e1

<td><a href="property_types.html#boolean">boolean</a></td>

We interchange boolean/Boolean and integer/Integer types.

checkstyle/src/xdocs/config_naming.xml

Line 57 in 20506e1

<td><a href="property_types.html#integer">3</a></td>

We have improper types, 3 instead of Integer.

For default values:

checkstyle/src/xdocs/config_coding.xml

Line 1789 in 20506e1

<td/>

checkstyle/src/xdocs/config_imports.xml

Line 54 in 20506e1

<td><code>empty list</code></td>

We interchange blanks with {}, all files, or empty list for sets depending on the context.

checkstyle/src/xdocs/config_javadoc.xml

Line 524 in 20506e1

<td><code>{}</code></td>

checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocPackageCheck.java

Line 60 in 20506e1

setFileExtensions("java");

Some default values are wrong.

There will be 2 hurdles with creating a junit for default values:

1. Bean fields must have the same name as the setter, which is what BeanUtil sees.
   

   checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/TranslationCheck.java

   Lines 190 to 191 in 20506e1

   	public void setBaseName(String baseName) {
   	baseNamePattern = CommonUtils.createPattern(baseName);

[romani]

@rnveach ,

please move " We use String in the setter for everything, from regular expressions, file locations, to
custom enumerations." to separate issue, it will not be a just clean up .

[rnveach]

I moved it.

[romani]

For types:

is done.

For default values:

is NOT done yet.

[romani]

@rnveach , is smth left as not-fixed here ?

[rnveach]

@romani Until we align all types in Issue #3212, we can't fully validate strings.
Right now setters are String type, but are then converted to Patterns and custom enumerations. All we see is String right now, so we can't tell the difference to accurately say if it is a String or something else.

These are the current overrides that need to be removed for full validation:

checkstyle/src/test/java/com/puppycrawl/tools/checkstyle/internal/XDocsPagesTest.java

Line 541 in c58874e

else if (clss != String.class) {

checkstyle/src/test/java/com/puppycrawl/tools/checkstyle/internal/XDocsPagesTest.java

Line 586 in c58874e

if (clss != String.class && clss != String[].class && result == null) {

[romani]

issue is too big, please split into separate issue (it will be non "miscellaneous" update ) and close this issue.

[rnveach]

Closed because issue is split