Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pgjdbc project at NoErrorTest group of tests #3670

Closed
romani opened this issue Dec 19, 2016 · 3 comments
Closed

add pgjdbc project at NoErrorTest group of tests #3670

romani opened this issue Dec 19, 2016 · 3 comments
Labels
approved miscellaneous
Milestone
7.5

Comments

@romani
Copy link
Member

romani commented Dec 19, 2016

https://github.com/pgjdbc/pgjdbc
Error is used as severity - https://github.com/pgjdbc/pgjdbc/blob/master/pgjdbc/pom.xml#L268

So could be used as noViolation project - https://github.com/checkstyle/checkstyle/blob/master/wercker.yml
@romani romani changed the title add pgjdbc project to NoViolation tests add pgjdbc project at NoErrorTest group of tests Dec 19, 2016
@romani romani mentioned this issue Dec 29, 2016
Merged
@romani
Copy link
Member Author

romani commented Dec 29, 2016

issue against pgjdbc to resolve all violations from our recent version - pgjdbc/pgjdbc#724

@romani
Copy link
Member Author

romani commented Dec 29, 2016

#3678 need to be addressed to let us enforce checkstyle validation.

romani added a commit that referenced this issue Jan 9, 2017
@romani
Issue #3670: add pgjdbc project at NoErrorTest group of tests (wercke…
4cd4390 
…r ci)
@romani romani mentioned this issue Jan 9, 2017
Merged
romani added a commit that referenced this issue Jan 10, 2017
@romani
Issue #3670: add pgjdbc project at NoErrorTest group of tests (wercke…
b3849a2 
…r ci)
@romani romani added this to the 7.5 milestone Jan 10, 2017
@romani
Copy link
Member Author

romani commented Jan 10, 2017

fix is merged

@romani romani closed this as completed Jan 10, 2017
@MEZk MEZk mentioned this issue Feb 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved miscellaneous
Projects
None yet
Milestone
7.5
Development

No branches or pull requests
1 participant
@romani