New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong German translation of declaration.order.access in messages_de.properties #4081

Closed
sirdis opened this Issue Mar 22, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@sirdis
Contributor

sirdis commented Mar 22, 2017

In the file src/main/resources/com/puppycrawl/tools/checkstyle/checks/coding/messages_de.properties, the value of property "declaration.order.access" changed to "Es wird auf eine Variable zugegriffen, bevor diese deklariert wurde." This seems to have happened in commit 165fb0b, before that it was correctly "Fehlerhafte Deklarationsreihenfolge für diesen Scope."

If there is a situation where the new value describes the warning correctly, the property should be split into two. Otherwise I suggest to revert to the old value.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Mar 22, 2017

Member

@sirdis , please send us PR please.

Member

romani commented Mar 22, 2017

@sirdis , please send us PR please.

sirdis added a commit to sirdis/checkstyle that referenced this issue Mar 23, 2017

@sirdis

This comment has been minimized.

Show comment
Hide comment
@sirdis

sirdis Mar 23, 2017

Contributor

Ok, created the PR. Fixed a few typos in other places of the properties file, too. Furthermore, the keys "fall.through" and "fall.through.last" have values that are syntactically incomplete German sentences. Since I don't understand the intention of the original author, I left them unchanged.

Contributor

sirdis commented Mar 23, 2017

Ok, created the PR. Fixed a few typos in other places of the properties file, too. Furthermore, the keys "fall.through" and "fall.through.last" have values that are syntactically incomplete German sentences. Since I don't understand the intention of the original author, I left them unchanged.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Mar 23, 2017

Member

have values that are syntactically incomplete German sentences.

if they are incomplete - just provide your translation for such sentences. We do not have maintainers who know German, so we rely on community only.

Member

romani commented Mar 23, 2017

have values that are syntactically incomplete German sentences.

if they are incomplete - just provide your translation for such sentences. We do not have maintainers who know German, so we rely on community only.

sirdis added a commit to sirdis/checkstyle that referenced this issue Mar 23, 2017

sirdis added a commit to sirdis/checkstyle that referenced this issue Mar 23, 2017

sirdis added a commit to sirdis/checkstyle that referenced this issue Mar 23, 2017

romani added a commit that referenced this issue Mar 23, 2017

@romani romani added this to the 7.7 milestone Mar 23, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Mar 23, 2017

Member

fix is merged, thanks a lot

Member

romani commented Mar 23, 2017

fix is merged, thanks a lot

@romani romani closed this Mar 23, 2017

GitToasterhub added a commit to GitToasterhub/checkstyle that referenced this issue Mar 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment