-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build fails on cobertura:check goal #4450
Comments
@Nimfadora Put all information here in first post, including errors you were getting during build. I am unable to reproduce locally.
grammar isn't 100% covered as it is dynamically generated code not built by us. |
@rnveach I added information you asked to add. I have updated java to 1.8.0_131 but it doesn't resolve the issue. Here is an example of cobertura: https://nimfadora.github.io/cobertura.html |
@rnveach @romani
|
Investigation: Iteration 1 Iteration 2 59b7c69 - OK @Nimfadora
Mocking of final classes is a very bad hack! |
commit 59b7c69 commit 27e1e94 So it is not the case. I continue investigating. |
Interesting fact, I tried on another computer |
We did a fix to this commit just recently, c6981b8. I'm unable to reproduce the problem on the 3 machines I have, windows and linux. Can one of you confirm what initially causes it for 27e1e94 ? |
Not, it did not fix the problem. |
That is why we use powermock. It is better to do have hacks in test code vs bad design in main code I do have the same problem on my local: |
There is a similar issue reported at cobertura/cobertura#308 for cobertura. Cobertura hasn't released anything in 2 years. Otherwise, unless we find specific code we can rewrite, I think we may be stuck with this issue. |
@romani @Nimfadora |
I didn't realize this as it wasn't on our wiki page, but I thought the reason we stayed away from jacoco is because it can't work with powermock yet. See https://github.com/powermock/powermock/wiki/Code-coverage-with-JaCoCo . This is the results of jacoco run in my branch on master:
|
Running
|
Problematic tests:
|
Yes, sometimes it appears again during I removed @RunWith(PowerMockRunner.class)
@PrepareForTest(TreeWalker.class) and 4 UTs (TreeWalkerTest)
and ran |
Updated Linux kernel to: 4.4.0-83-generic |
for me it is failing only on one of my box, but fails stable. FAILING ON:
DOES NOT FAIL:
|
I tried to reproduce it on Travis with command that failed on my side |
@Nimfadora and @MEZk , I merged refactoring to test to avoid over mocking. |
master branch build fails on cobertura:check goal
issue is reproduced here
Apache Maven 3.3.9
Java version: 1.8.0_121, vendor: Oracle Corporation
cobertura coverage report is here
cobertura line rate specified in pom:
<totalLineRate>99</totalLineRate>
cobertura line rate in report: 98
Seems that api package or grammars package is not covered as needed.
mvn clean verify produces such error:
CI is failing with this error:
The text was updated successfully, but these errors were encountered: