New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split and Organize Checkstyle inputs by Test for checks in 'checks' package #4587

Closed
romani opened this Issue Jul 2, 2017 · 7 comments

Comments

Projects
None yet
2 participants
@romani
Member

romani commented Jul 2, 2017

subtask of #3891

Move / Make a copy of all test input files to a separate folder for all checks in 'checks' package.
Not any other Check should use new inputs.

Attention: that is bit different issue. We need to create folder "..../checks/misc". In "misc" folder put files as we do in all other issues of this series: "misc/transaltion/Input..... .java", "misc/upperl/ ......" ,...

There are a lot of other issues/commit that named as "Split and Organize Checkstyle inputs ..." , you can find example of what to do there.

all files should in subfolders - https://github.com/checkstyle/checkstyle/tree/master/src/test/resources/com/puppycrawl/tools/checkstyle/checks

@romani romani changed the title from Split and Organize Checkstyle inputs by Test for checks in checks package to Split and Organize Checkstyle inputs by Test for checks in 'checks' package Jul 2, 2017

@Kietzmann

This comment has been minimized.

Show comment
Hide comment
@Kietzmann

Kietzmann Jul 5, 2017

Contributor

I'm on it
If I've correctly understood, we need to clean up checks package from input files which are related to tests that are located directly in 'checks' package?

Contributor

Kietzmann commented Jul 5, 2017

I'm on it
If I've correctly understood, we need to clean up checks package from input files which are related to tests that are located directly in 'checks' package?

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 5, 2017

Member

yes

Member

romani commented Jul 5, 2017

yes

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 5, 2017

Member

@Kietzmann , reminder, please do PR for each Check update.

Member

romani commented Jul 5, 2017

@Kietzmann , reminder, please do PR for each Check update.

@Kietzmann

This comment has been minimized.

Show comment
Hide comment
@Kietzmann

Kietzmann Jul 5, 2017

Contributor

@romani
Oops
may for first two updates it'll be in one PR?

Contributor

Kietzmann commented Jul 5, 2017

@romani
Oops
may for first two updates it'll be in one PR?

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 5, 2017

Member

ok, but please try to keep PR of easy to review size, if some case might be unclear please do comment in description.

Member

romani commented Jul 5, 2017

ok, but please try to keep PR of easy to review size, if some case might be unclear please do comment in description.

@Kietzmann

This comment has been minimized.

Show comment
Hide comment
@Kietzmann

Kietzmann Jul 5, 2017

Contributor

ok

Contributor

Kietzmann commented Jul 5, 2017

ok

Kietzmann pushed a commit to Kietzmann/checkstyle that referenced this issue Jul 5, 2017

Kietzmann pushed a commit to Kietzmann/checkstyle that referenced this issue Jul 5, 2017

Kietzmann pushed a commit to Kietzmann/checkstyle that referenced this issue Jul 5, 2017

Kietzmann pushed a commit to Kietzmann/checkstyle that referenced this issue Jul 5, 2017

Kietzmann pushed a commit to Kietzmann/checkstyle that referenced this issue Jul 5, 2017

romani added a commit that referenced this issue Jul 5, 2017

romani added a commit that referenced this issue Jul 5, 2017

@romani romani added the miscellaneous label Jul 5, 2017

romani added a commit that referenced this issue Jul 5, 2017

romani added a commit that referenced this issue Jul 5, 2017

Kietzmann pushed a commit to Kietzmann/checkstyle that referenced this issue Jul 6, 2017

Dmytro Kytsmen
Issue #4587: Moved all necessary resource files for NewlineAtEndOfFil…
…eCheckTest, made a copy of InputNewlineCrAtEndOfFile, renamed one resource file cause it is using in other test, changed suppressions due to file move

Kietzmann pushed a commit to Kietzmann/checkstyle that referenced this issue Jul 6, 2017

Kietzmann pushed a commit to Kietzmann/checkstyle that referenced this issue Jul 6, 2017

romani added a commit that referenced this issue Jul 6, 2017

Kietzmann pushed a commit to Kietzmann/checkstyle that referenced this issue Jul 6, 2017

romani added a commit that referenced this issue Jul 6, 2017

Kietzmann pushed a commit to Kietzmann/checkstyle that referenced this issue Jul 7, 2017

Kietzmann pushed a commit to Kietzmann/checkstyle that referenced this issue Jul 7, 2017

Kietzmann pushed a commit to Kietzmann/checkstyle that referenced this issue Jul 7, 2017

Kietzmann pushed a commit to Kietzmann/checkstyle that referenced this issue Jul 7, 2017

romani added a commit that referenced this issue Jul 7, 2017

romani added a commit that referenced this issue Jul 7, 2017

romani added a commit that referenced this issue Jul 7, 2017

romani added a commit that referenced this issue Jul 7, 2017

Kietzmann pushed a commit to Kietzmann/checkstyle that referenced this issue Jul 7, 2017

romani added a commit that referenced this issue Jul 7, 2017

Kietzmann pushed a commit to Kietzmann/checkstyle that referenced this issue Jul 7, 2017

romani added a commit that referenced this issue Jul 7, 2017

Kietzmann added a commit to Kietzmann/checkstyle that referenced this issue Jul 8, 2017

romani added a commit that referenced this issue Jul 8, 2017

Kietzmann added a commit to Kietzmann/checkstyle that referenced this issue Jul 8, 2017

romani added a commit that referenced this issue Jul 9, 2017

Kietzmann added a commit to Kietzmann/checkstyle that referenced this issue Jul 9, 2017

romani added a commit that referenced this issue Jul 9, 2017

@romani romani added this to the 8.1 milestone Jul 9, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 9, 2017

Member

all input files were moved to subfolders.

@Kietzmann , thanks a lot for your update !

Member

romani commented Jul 9, 2017

all input files were moved to subfolders.

@Kietzmann , thanks a lot for your update !

@romani romani closed this Jul 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment