Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UniquePropertiesCheck.getLineNumber should be private #4694

Closed
romani opened this issue Jul 10, 2017 · 2 comments
Closed

UniquePropertiesCheck.getLineNumber should be private #4694

romani opened this issue Jul 10, 2017 · 2 comments
Labels
approved miscellaneous
Milestone
8.1

Comments

@romani
Copy link
Member

romani commented Jul 10, 2017

Checks are not designed for extension in general, so protected usage is discouraged
especially static protected
protected static int getLineNumber(FileText fileText, String keyName) {
https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/checks/UniquePropertiesCheck.java#L104

should become private protected. UTs should be updated to use Check public methods to test functionality.
@romani romani mentioned this issue Jul 10, 2017
Merged
@djydewang
Copy link
Contributor

Is it OK to test functionality by using reflection?

@rnveach
Copy link
Member

rnveach commented Jul 12, 2017 •
edited

@djydewang Yes, if there is no other way we are fine with reflection.

djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 12, 2017
@djydewang
Issue checkstyle#4694: UniquePropertiesCheck.getLineNumber should be …
92d2100 
…private
djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 12, 2017
@djydewang
Issue checkstyle#4694: UniquePropertiesCheck.getLineNumber should be …
5a5ee5b 
…private
@djydewang djydewang mentioned this issue Jul 12, 2017
Merged
djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 12, 2017
@djydewang
Issue checkstyle#4694: UniquePropertiesCheck.getLineNumber should be …
b21ee4b 
…private
djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 12, 2017
@djydewang
Issue checkstyle#4694: UniquePropertiesCheck.getLineNumber should be …
a6151b6 
…private
djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 13, 2017
@djydewang
Issue checkstyle#4694: UniquePropertiesCheck.getLineNumber should be …
4067dcd 
…private
djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 13, 2017
@djydewang
Issue checkstyle#4694: UniquePropertiesCheck.getLineNumber should be …
c2b3692 
…private
djydewang added a commit to djydewang/checkstyle that referenced this issue Jul 13, 2017
@djydewang
Issue checkstyle#4694: UniquePropertiesCheck.getLineNumber should be …
8cdd0b8 
…private
romani pushed a commit that referenced this issue Jul 13, 2017
@djydewang @romani
Issue #4694: UniquePropertiesCheck.getLineNumber should be private
8c08011
@romani romani added this to the 8.1 milestone Jul 13, 2017
@romani romani closed this as completed Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved miscellaneous
Projects
None yet
Milestone
8.1
Development

No branches or pull requests
3 participants
@romani @rnveach @djydewang