Issue #4641: Avoid usage of getLines method from FileText #4670
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4670 +/- ##
======================================
Coverage 100% 100%
======================================
Files 284 284
Lines 15367 15372 +5
Branches 3499 3500 +1
======================================
+ Hits 15367 15372 +5
Continue to review full report at Codecov.
|
| * @return line number of first occurrence. If no key found in properties | ||
| * file, 0 is returned | ||
| */ | ||
| protected static int getLineNumber(FileText fileText, String keyName) { |
There was a problem hiding this comment.
ideally it should be private, but will need it in Tests to avoid even deeper refactoring.
I will create separate issue on UT refactoring, it could be done later.
| @@ -104,9 +103,7 @@ protected void processFiltered(File file, FileText fileText) { | |||
| * file, 0 is returned | |||
| */ | |||
| protected static int getLineNumber(List<String> lines, String keyName) { | |||
There was a problem hiding this comment.
this method is not in use in Check so should be removed. Looks like it is required by Tests, Tests need to use new method.
timurt
force-pushed
the
4641
branch
2 times, most recently
from
9e55814
to
3711642
Compare
| * method return value. | ||
| */ | ||
| @Test | ||
| public void testNotFoundKey() { | ||
| public void testNotFoundKeyFileText() { |
There was a problem hiding this comment.
Why do we need FileText on the end of test name?
| * Processes a set of lines looking for matches. | ||
| * @param fileText {@link FileText} object contains the lines to process. | ||
| */ | ||
| public void processLines(FileText fileText) { |
There was a problem hiding this comment.
There is also a method public void processLines(List<String> lines).
Why is the other method remaining? Shouldn't it be swapped for this new method instead of keeping both?
There was a problem hiding this comment.
yes, you are right, done
|
@romani |
#4641