Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmptyLineSeparator doesn't require exactly one line between members #530

Closed
mkordas opened this issue Dec 21, 2014 · 3 comments
Closed

EmptyLineSeparator doesn't require exactly one line between members #530

mkordas opened this issue Dec 21, 2014 · 3 comments
Assignees
Labels

Comments

@mkordas
Copy link
Contributor

mkordas commented Dec 21, 2014

According to Google Java Style - Vertical Whitespace there must be only one line between class members. Current check doesn't enforce that, so it's incomplete. Please look at samples:

package com.sample;
import java.util.List; // as expected: 'import' should be separated from previous statement
package com.sample;

import java.util.List; // OK
package com.sample;


import java.util.List; // nothing reported, but violates Vertical Whitespace rules
@romani
Copy link
Member

romani commented Dec 22, 2014

that should be a new option of Check, by default Check should allow multiple empty lines

alexkravin added a commit to alexkravin/checkstyle that referenced this issue Jan 25, 2015
alexkravin added a commit to alexkravin/checkstyle that referenced this issue Jan 25, 2015
alexkravin added a commit to alexkravin/checkstyle that referenced this issue Jan 27, 2015
alexkravin added a commit to alexkravin/checkstyle that referenced this issue Jan 27, 2015
alexkravin added a commit to alexkravin/checkstyle that referenced this issue Jan 28, 2015
romani pushed a commit that referenced this issue Jan 29, 2015
@romani
Copy link
Member

romani commented Jan 29, 2015

will be in 6.3

@romani romani closed this as completed Jan 29, 2015
@romani romani reopened this Feb 1, 2015
@romani
Copy link
Member

romani commented Feb 1, 2015

problem is detected by google style test project - https://travis-ci.org/checkstyle/google-style-config-test/jobs/49054029

romani added a commit that referenced this issue Feb 1, 2015
…ines between class members, issue #530"

This reverts commit 3f853ae.
alexkravin added a commit to alexkravin/checkstyle that referenced this issue Feb 1, 2015
alexkravin added a commit to alexkravin/checkstyle that referenced this issue Feb 1, 2015
@romani romani closed this as completed Feb 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants