Empty Line Separator Check, added option for managing empty lines betwee...

[alexkravin]

...n class members, issue #530

Added option allowMultipleEmptyLines for managing empty lines between class members, default value is true.

Added corresponding UT and input file.

[romani]

build is failed.

// 3 is the number of the pre-previous line because the numbering starts from zero.

need more explanation on this, previous usually mean "-1", pre-previous "-2"

[alexkravin]

Corrected build.

About pre-previous line:
it was taken from existing method

checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/whitespace/EmptyLineSeparatorCheck.java

Line 296 in 378c68f

final String lineBefore = getLines()[lineNo - 2];

just analyzing previous line from this one.

Seems to be it's the feature of FileContents class from where getLines() is calling
(getLines() is method from Check which calls return getFileContents().getLines();)

[coveralls]

Coverage decreased (-0.01%) to 90.62% when pulling 378c68f on alexkravin:EmptyLineSeparatorCheck#530 into 204c073 on checkstyle:master.

[romani]

ok, but rename hasEmptyLinesBefore method to be named absolutely reflecting functionality. As "Lines" is not exact, and there is not argument that customize distance before.

[alexkravin]

renamed to isPrecededByMoreThanOneEmptyLine "line" is quite exact in this context, we don't need to take care about distance as we're looking for only "> 1 empty lines", so I think it's quite obvious.

[romani]

Build is failed.

Please send me link to line in code where you have " ... > 1" or " ... > 2" if lines are indexed from 0.

[alexkravin]

https://github.com/alexkravin/checkstyle/blob/4ca50aa2da01ff7477a8d043446aec864a8f435a/src/main/java/com/puppycrawl/tools/checkstyle/checks/whitespace/EmptyLineSeparatorCheck.java#L286

Here's checking line after token

https://github.com/alexkravin/checkstyle/blob/4ca50aa2da01ff7477a8d043446aec864a8f435a/src/main/java/com/puppycrawl/tools/checkstyle/checks/whitespace/EmptyLineSeparatorCheck.java#L298

Here's checking line before token (only previous line), my method is based on it.

[coveralls]

Coverage decreased (-0.0%) to 90.64% when pulling 4ca50aa on alexkravin:EmptyLineSeparatorCheck#530 into c6019cd on checkstyle:master.

[romani]

Please send me link to line in code where you have " ... > 1" or " ... > 2" if lines are indexed from 0.

I meant in isPrecededByMoreThanOneEmptyLine method. Method named incorrectly.

[alexkravin]

generally speaking, this method checks only pre-previous line, in context of Check couple of methods are checking "more than 1 empty line before", so I renamed this method to isPrePreviousLineEmpty because it checks exactly pre-previous line.

[coveralls]

Coverage increased (+0.01%) to 90.64% when pulling 8db2b14 on alexkravin:EmptyLineSeparatorCheck#530 into f46ec1b on checkstyle:master.

[romani]

merged as FF