Log severity for all audit events, not just warnings

[richarddbarnett]

DefaultLogger.addError() only logs AuditEvent.severityLevel if it's WARNING.
This makes it hard to find events of severity ERROR in eg mvn checkstyle:check output.
Log severityLevel in all cases.

[richarddbarnett]

Patch (based on 5.3) that unfortunately breaks many unit tests:

diff -r 1b7a252d5e1e src/checkstyle/com/puppycrawl/tools/checkstyle/DefaultLogger.java
--- a/src/checkstyle/com/puppycrawl/tools/checkstyle/DefaultLogger.java Tue Oct 19 18:56:17 2010 +1000
+++ b/src/checkstyle/com/puppycrawl/tools/checkstyle/DefaultLogger.java Wed Feb 22 11:38:12 2012 +1100
@@ -109,9 +109,7 @@
             if (aEvt.getColumn() > 0) {
                 sb.append(':').append(aEvt.getColumn());
             }
-            if (SeverityLevel.WARNING.equals(severityLevel)) {
-                sb.append(": warning");
-            }
+            sb.append(": ").append(severityLevel.getName());
             sb.append(": ").append(message);
             mErrorWriter.println(sb.toString());
         }

[romani]

valid point, patch is correct on 5.7-Snapshot, but ...

DefaultLogger is used in UTs, so it have to be updated to have property that will manage printing of Severity - "boolean printSeverity", by default for UTs it will be disabled to satisfy all existing UTs. In class that option will be "true" by default.
WriteTagCheckTest.testTagSeverity() - is only UT that would fail but it have to be updated to create Logger (BaseCheckTestSupport have to be extended with

createChecker(....., boolean printSeverity) {
....
c.addListener(new BriefLogger(mStream, printSeverity));
}

for himself with printing severity level.

@richarddbarnett, if you need this fix .... please follow instructions above in other case wait .

[alexkravin]

If I understood everything correct..

In all places except for UTs this option is used with its default value (true), so new option was added to DefaultLogger's ctors and all calls of these ctors are updated with true value, except for BaseCheckTestSupport.

New createChecker() and verify() methods were introduced in BaseCheckTestSupport to support the setting of new option.

[romani]

fixed, will be in 6.5

[romani]

compatibility problem should be resolved https://groups.google.com/forum/#!topic/checkstyle-devel/3jJ4cCQ3sM0

I revered as commit from master, now checkstyle-tester project (https://github.com/checkstyle/contribution/tree/master/checkstyle-tester) works fine

[alexkravin]

Corresponding instantiation just have to be updated according to new params

[romani]

We can not wait for plugin to update that, maven plugin is still on very old version.
Please provide a solution to resolve that issue and do not brake compatibility.

[MEZk]

@romani
Is it a good idea to implement setter for printSeverity variable instead of initialization in constructor?

[romani]

Not the best, i think that one mor c-tor will be better solution

[romani]

merged