Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doc for MissingCtor #7667

Closed
strkkk opened this issue Feb 25, 2020 · 2 comments · Fixed by #8201
Closed

Update doc for MissingCtor #7667

strkkk opened this issue Feb 25, 2020 · 2 comments · Fixed by #8201
Labels
approved good first issue miscellaneous
Milestone
8.33

Comments

@strkkk
Copy link
Member

strkkk commented Feb 25, 2020 •
edited by romani
Loading

https://checkstyle.org/config_coding.html#MissingCtor

Add example for each existing config to show what code is ok and what code cause violation.
Good example is https://checkstyle.org/config_naming.html#AbstractClassName
Look at referenced commits of #5832, to see what and how should be changed in code.

Please play with module/check by means of https://checkstyle.org/cmdline.html to understand how it works.

PLEASE READ https://github.com/checkstyle/checkstyle/wiki/Good-practice-on-how-to-update-examples
@xkarx
Copy link

xkarx commented Mar 1, 2020

I am on it

@romani romani removed the easy label Mar 5, 2020
@Gaurav-Punjabi
Copy link
Contributor

I'm on it

Gaurav-Punjabi added a commit to Gaurav-Punjabi/checkstyle that referenced this issue Apr 27, 2020
@Gaurav-Punjabi
Issue checkstyle#7667: Update doc for MissingCtor
52ef2b3
@Gaurav-Punjabi Gaurav-Punjabi mentioned this issue Apr 27, 2020
Merged
Gaurav-Punjabi added a commit to Gaurav-Punjabi/checkstyle that referenced this issue Apr 28, 2020
@Gaurav-Punjabi
Issue checkstyle#7667: Update doc for MissingCtor
89b2bef
Gaurav-Punjabi added a commit to Gaurav-Punjabi/checkstyle that referenced this issue Apr 28, 2020
@Gaurav-Punjabi
Issue checkstyle#7667: Update doc for MissingCtor
305904d
Gaurav-Punjabi added a commit to Gaurav-Punjabi/checkstyle that referenced this issue Apr 28, 2020
@Gaurav-Punjabi
Issue checkstyle#7667: Update doc for MissingCtor
7aad42b
Gaurav-Punjabi added a commit to Gaurav-Punjabi/checkstyle that referenced this issue Apr 28, 2020
@Gaurav-Punjabi
Issue checkstyle#7667: Update doc for MissingCtor
bcf2862
strkkk pushed a commit that referenced this issue Apr 29, 2020
@Gaurav-Punjabi @strkkk
Issue #7667: Update doc for MissingCtor
439d563
@strkkk strkkk added this to the 8.33 milestone Apr 29, 2020
Gaurav-Punjabi added a commit to Gaurav-Punjabi/checkstyle that referenced this issue Apr 29, 2020
@Gaurav-Punjabi
Issue checkstyle#7667: Update doc for MissingCtor
4f9ba3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved good first issue miscellaneous
Projects
None yet
Milestone
8.33
Development

Successfully merging a pull request may close this issue.

Issue #7667: Update doc for MissingCtor Gaurav-Punjabi/checkstyle
4 participants
@romani @strkkk @Gaurav-Punjabi @xkarx