Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value 'empty' in metadata files for 'tokens' property cause problems in plugins #8916

Closed
romani opened this issue Oct 22, 2020 · 1 comment
Closed
Milestone

Comments

@romani
Copy link
Member

romani commented Oct 22, 2020

https://checkstyle.org/config_misc.html#DescendantToken_Properties
https://checkstyle.org/config_coding.html#IllegalTokenText_Properties

example:
image

image
but in meta it is:

<property default-value="empty" name="tokens" type="anyTokenTypesSet">
<description>tokens to check</description>
</property>

<property default-value=""
name="tokens"
type="java.lang.String[]"
validation-type="tokenSet">

both this Checks have empty tokens property, in WEB documentation we cannot render empty value, so we put empty word. But in metadata and javadoc we should be strict and be more technical, so value should be empty string value.

such problem in metadata caused problems described at checkstyle/sonar-checkstyle#338 (comment)

@romani
Copy link
Member Author

romani commented Oct 27, 2020

Fix is merged

@romani romani closed this as completed Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant