Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #11564: Wercker service will be shutdown on October 31st, 2022 #11670

Merged
merged 1 commit into from
May 29, 2022
Merged

Issue #11564: Wercker service will be shutdown on October 31st, 2022 #11670

merged 1 commit into from
May 29, 2022

Conversation

Rahulkhinchi03
Copy link
Contributor

@Rahulkhinchi03 Rahulkhinchi03 commented May 25, 2022 •
edited
Loading

Resolves #11564

Child Issue created in contribution repository: checkstyle/contribution#607
PR for child issue: checkstyle/contribution#608

@Rahulkhinchi03
Copy link
Contributor Author

  • Need Confirmation, Should I remove the sonarqube job from validation.sh as it has been moved to GitHub Actions. (It uses wercker in comment)

checkstyle/.ci/validation.sh

Lines 552 to 558 in 962865b

# executed only in wercker for security reasons
sonarqube)
# token could be generated at https://sonarcloud.io/account/security/
# execution on local for master:
# SONAR_TOKEN=xxxxxx ./.ci/wercker.sh sonarqube
# execution on local for non-master:
# SONAR_TOKEN=xxxxxx PR=xxxxxx WERCKER_GIT_BRANCH=xxxxxx ./.ci/wercker.sh sonarqube

@romani
Copy link
Member

romani commented May 29, 2022

CIs restarted.
Ok to merge as CI pass.

Sonarqube should be executed in GitHub actions. So no changes are required.

romani
romani approved these changes May 29, 2022
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@romani romani merged commit 3ca6f75 into checkstyle:master May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani romani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wercker service will be shutdown on October 31st, 2022
2 participants
@Rahulkhinchi03 @romani