Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #607: Wercker service will be shutdown on October 31st, 2022 #608

Merged
merged 1 commit into from
May 29, 2022
Merged

Issue #607: Wercker service will be shutdown on October 31st, 2022 #608

merged 1 commit into from
May 29, 2022

Conversation

Rahulkhinchi03
Copy link
Contributor

Resolves #607

@Rahulkhinchi03 Rahulkhinchi03 mentioned this pull request May 25, 2022
Merged
@rnveach rnveach self-assigned this May 26, 2022
@rnveach
Copy link
Member

rnveach commented May 26, 2022 •
edited

@romani ping on TC failures here. ( Connected to #606 ) . Wasn't sure if the version here could be rolled back or its something else.

rnveach
rnveach approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@rnveach rnveach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rahulkhinchi03 You confirmed everything else is the same, including the exclusions?

@rnveach rnveach assigned romani and unassigned rnveach May 26, 2022
@rnveach rnveach requested a review from romani May 26, 2022 19:33
@Rahulkhinchi03
Copy link
Contributor Author

@Rahulkhinchi03 You confirmed everything else is the same, including the exclusions?

@rnveach Yes, I have cross-checked it.

romani
romani approved these changes May 29, 2022
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge, TC is not related.
We need to fix it in separate PR.

@romani romani merged commit f26d956 into checkstyle:master May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani romani approved these changes

@rnveach rnveach rnveach approved these changes

Assignees

@romani romani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wercker service will be shutdown on October 31st, 2022
3 participants
@Rahulkhinchi03 @rnveach @romani