Issue #14937: Migrated section 3.2 Package Statement to follow chapter wise testing #15001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zopsss
force-pushed
the
package-statement
branch
3 times, most recently
from
0b4dbed
to
053df1d
Compare
|
GitHub, generate site |
Zopsss
force-pushed
the
package-statement
branch
2 times, most recently
from
5a08a7b
to
0d506cd
Compare
|
I had to explicitly create a new test file to test very long package statement. It was not possible to do in single test file as the package names would be different ( rule32packagestatement & toolongpackagetotestcoveragegooglesjavastylerule): |
Zopsss
force-pushed
the
package-statement
branch
from
0d506cd
to
8420b54
Compare
|
GitHub, generate site |
romani
requested changes
Jun 17, 2024
...ogle/checkstyle/test/chapter3filestructure/rule32packagestatement/InputPackageStatement.java
Outdated
Show resolved
Hide resolved
romani
requested changes
Jun 17, 2024
.../java/com/google/checkstyle/test/chapter3filestructure/rule332nolinewrap/LineLengthTest.java
Show resolved
Hide resolved
...ter3filestructure/toolongpackagetotestcoveragegooglesjavastylerule/PackageStatementTest.java
Show resolved
Hide resolved
.../chapter3filestructure/toolongpackagetotestcoveragegooglesjavastylerule/InputLineLength.java
Show resolved
Hide resolved
Zopsss
force-pushed
the
package-statement
branch
from
8420b54
to
c0d7a21
Compare
|
can you restart the CI for cancelled checks? @romani |
|
lets see if we can migrate - #15023 |
Zopsss
force-pushed
the
package-statement
branch
from
c0d7a21
to
6521bff
Compare
romani
requested changes
Jun 18, 2024
...er3filestructure/toolongpackagetotestcoveragegooglesjavastylerule/InputPackageStatement.java
Outdated
Show resolved
Hide resolved
Zopsss
force-pushed
the
package-statement
branch
from
6521bff
to
30e9e18
Compare
Zopsss
force-pushed
the
package-statement
branch
from
30e9e18
to
991f6bf
Compare
Zopsss
force-pushed
the
package-statement
branch
from
991f6bf
to
381fccd
Compare
…low chapter wise testing
Zopsss
force-pushed
the
package-statement
branch
from
381fccd
to
245f4fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #14937
migrated section
3.2 Package Statementto follow chapter wise testing.This section uses 2 modules: LineLength & NoLineWrap.
section 3.3.2 uses LineLength module too, it had input file for it but did not had test class. It was using section 3.2's test class. So technically we had the line length's input file for section 3.3.2 but we were not using it anywhere in the test class.
And I had to combine the LineLength & NoLineWrap module test classes into single test class for section 3.2. So I created a new test class for LineLength module for section 3.3.2 which uses the correct input file.
We had a very long package statement input file for section 3.2 to test that we allow for very long package statements but we were not using it anywhere in the test class, so I created a new test class for it.
Deleted unnecessary code which did not contributed to ensure the correct implementation of the section from input files.
Also corrected the
testurl for section 4.4