Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: update azure to macOS-12 to avoid deprecation warning #15023

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

romani
Copy link
Member

@romani romani commented Jun 18, 2024

from #15001 (comment)

it becomes a pain to restart.

##[error]This is a scheduled macOS-11 brownout. The macOS-11 environment 
is deprecated and will be removed on June 28th, 2024.
,##[error]The remote provider was unable to process the request.
Started: Yesterday at 10:53 AM
Duration: 20h 8m 52s

Job preparation parameters
9 queue time variables used

https://dev.azure.com/romanivanovjr/romanivanovjr/_build/results?buildId=21757&view=logs&j=d72e04f6-d294-5bfe-b3cd-ffcb523f40f9

@Zopsss
Copy link
Contributor

Zopsss commented Jun 18, 2024

@romani
Copy link
Member Author

romani commented Jun 18, 2024

Looks like this code is returned non zero exit code

checkstyle/.ci/validation.sh

Lines 1137 to 1149 in 0c86b2f

ci-temp-check)
fail=0
mkdir -p .ci-temp
if [ -z "$(ls -A .ci-temp)" ]; then
echo "Folder .ci-temp/ is empty."
else
echo "Folder .ci-temp/ is not empty. Verification failed."
echo "Contents of .ci-temp/:"
fail=1
fi
ls -A .ci-temp
sleep 5s
exit $fail

From log

usage: sleep seconds

It might be that sleep command changes arguments, we can remove this sleep, it is from time we used Travis heavily and it had problem of logs being cut due to quick shutdown of failed containers.

@rnveach
Copy link
Member

rnveach commented Jun 18, 2024

we can remove this sleep, it is from time we used Travis heavily and it had problem of logs being cut

https://github.com/search?q=repo%3Acheckstyle%2Fcheckstyle%20%22ci-temp-check%22&type=code
All CIs should be manually checked to ensure removing this won't be an issue.

@romani
Copy link
Member Author

romani commented Jun 18, 2024

This sleep was Travis hack,
We still have it more explicitly

- sleep 5s

But unfortunately it was leaked to shell commands, as long time ago we run all on Travis and it was most powerful CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants