Issue 3105

[rnveach]

Issue #3105

First part of the changes to the test.
We now verify that the input file has the same indentation as the CS violation and has the same expected indentations as the CS violation. The test still can't fully verify non-CS violation comments.

Comments now have a new attribute, ioffset (short for indent offset). This is used when the CS violation's current indentation is different than the indentation of the first character found in the line. It's default value is 0. Reasoning why needed.
CS reported violation indent = indent + ioffset.
Note: Some places where we use this with a large value may have to be inspected as possible issues.

Other changes include streamlining test code by removing excess regular expressions, new audit listener to grab the violations, and having a single class hold all the data on the comment's attributes. All the original check and balances still remain.

[romani]

@rnveach ,

I do not like ioffset , but I am ok with it for temporal solution before we fix problem in Check.
Do you want me to merge this PR (I hope such parameter should be removed after bug in Check is fixed.) ? please open issue on this first.

[rnveach]

@romani Lets merge and use new issue to verify if they will stay or not.
Some ioffset may be removed, but I think others will stay.
Indentation can throw a violation on any node in the line, there is no guarantee that it will always be the first in the line, unless we are going to make this a requirement. indent is the indentation of the first node in the line. If we are to validate it in the violation message, then ioffset must stay for violations that are not referencing the same node as indent.

[romani]

please do issue first.

[rnveach]

@romani Issue is open.

[romani]

merged as FF