Issue #2186: Exception message extended to provide more information on incorrect parent

[subkrish]

Issue #2186

[codecov-io]

Codecov Report

Merging #4166 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #4166   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         283     283           
  Lines       14824   14824           
  Branches     3389    3389           
======================================
  Hits        14824   14824

Impacted Files	Coverage Δ
...va/com/puppycrawl/tools/checkstyle/TreeWalker.java	100% <ø> (ø)	⬆️
...puppycrawl/tools/checkstyle/api/AutomaticBean.java	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d876c65...775da65. Read the comment docs.

[Vladlis]

Checks -> Check

[subkrish]

Done.

[rnveach]

No tests need changing because the current test just checks the start of the message and we only changed the end.

checkstyle/src/test/java/com/puppycrawl/tools/checkstyle/TreeWalkerTest.java

Line 130 in 7c2f448

assertTrue(exception.getMessage().contains("TreeWalker is not allowed as a parent of"));

[rnveach]

Since we are changing this message, I think we should also change the default one in AutomaticBean.

checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/api/AutomaticBean.java

Line 273 in 3bd3a52

throw new CheckstyleException(childConf.getName() + " is not allowed as a child in "

childConf.getName() + " is not allowed as a child in " + getConfiguration().getName()

@romani You ok with this?

[romani]

@subkrish , please apply suggestion from @rnveach . I am ok with new message. Ready to merge.

[subkrish]

@romani @rnveach Changes have been made. Please review.

[rnveach]

@romani Please review and merge.