Issue #4410: Do not allow whitespace after @ sign #4412
Conversation
There was a problem hiding this comment.
Please generate diff report for your changes to make sure we don't see any issues.
https://github.com/checkstyle/contribution/tree/master/checkstyle-tester#diffgroovy-diff-report-generation
| @@ -286,4 +286,11 @@ public void parentheses() { | |||
|
|
|||
| public static void testNoWhitespaceBeforeEllipses(String ... args) { | |||
| } | |||
|
|
|||
| @ interface WithWhitespace {} | |||
There was a problem hiding this comment.
Please add some good cases where no violation is produced.
Also add one with line breaks after instead of space.
| @@ -86,6 +87,7 @@ | |||
| public int[] getDefaultTokens() { | |||
| return new int[] { | |||
| TokenTypes.ARRAY_INIT, | |||
| TokenTypes.AT, | |||
There was a problem hiding this comment.
@romani Please confirm it is ok to be default.
I don't see anything wrong as most people don't write with space after.
|
@strkkk , to resolve CIs, please rebase. |
Codecov Report
@@ Coverage Diff @@
## master #4412 +/- ##
======================================
Coverage 100% 100%
======================================
Files 285 285
Lines 15292 15292
Branches 3477 3477
======================================
Hits 15292 15292
Continue to review full report at Codecov.
|
|
@strkkk number of commits must remain as one. You must also rebase on latest master. |
|
@rnveach Rebase - done. |
It is an issue with wercker. They don't allow anonymous viewing. |
|
@strkkk , as already mentioned:
|
|
@strkkk ping |
|
@rnveach yes, I am here. I think I will finish it on weekend. |
|
Please also rebase on latest master, we did travis fix, it should pass. |
|
checkstyle 8.0 was released, please rebase on latest master. |
|
@strkkk , are you still plan to finish this PR ? |
|
@strkkk , to resolve wercker problem please rebase on our latest master |
|
we released 8.2 version, please rebase all your PRs to our latest master to avoid CI problems. This PR is abandoned .... any contributor is ok to continue |
|
looks like we lost connection to contributor. |
|
work will be continued at #5108 |
Issue #4410